Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): remove lifecycle listener after component unmount #3489

Conversation

YangJonghun
Copy link
Collaborator

Update the changelog

Provide an example of how to test the change

Describe the changes

  • remove lifecycle listener after component unmount

Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

@KrzysztofMoch KrzysztofMoch merged commit 3858a15 into TheWidlarzGroup:master Jan 20, 2024
3 checks passed
@YangJonghun YangJonghun deleted the fix/android-cleanup-resources branch January 20, 2024 12:32
Copy link
Contributor

@BasixKOR BasixKOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a better place to handle this. Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants