fix(android): keep screen on fullscreen

[gkueny]

Summary

add KEEP_SCREEN_ON flag when video is fullscreen & playing to avoid phone to go off.

inspired by expo/expo@2d84661

Motivation

On some Android, phone can go off while video is playing in fullscreen
see #3552

Changes

While we are in fullscreen, we check each 200ms if video is playing or not.

• If yes we set FLAG_KEEP_SCREEN_ON to fullscreen view
• If not we remove FLAG_KEEP_SCREEN_ON from fullscreen view

Test plan

• Setup sleep mode of your real android device to 15s

• Install https://github.com/gkueny/FullScreenModeTurnOffAndroidReproduction

• run it on an real android device

  • check that you reproduce the bug (not all devices reproduce it)

• Install the patch

yarn add react-native-video@https://github.com/gkueny/react-native-video.git#4963a591ea7f18b8084ff2aac7df10927f2b0c4e

• run it on an real android device

  • check that if you go fullscreen & video do not play , your phone go off after configured sleep time
  • check that if you go fullscreen & video play , your phone do not go off after configured sleep time
  • check that if you go fullscreen & video play & you stop the video , your phone go off after configured sleep time

• Update code to set preventsDisplaySleepDuringVideoPlayback to false & run it on an real android device

  • check that if you go fullscreen & video do not play , your phone go off after configured sleep time
  • check that if you go fullscreen & video play , your phone go off after configured sleep time
  • check that if you go fullscreen & video play & you stop the video , your phone go off after configured sleep time

[freeboub]

but, it will not work if you go to fullscreen while playback is paused ? btw, in 'normal' exoplayer integration, the flag is removed when the playback is paused...
Please double check following use case:

• when you pause player, the flag is removed (ie, keepScreenOn is disabled)
• when you player full screen while you are pause and then start playback, the flag shall be enable once playback is started (ie, keepScreenOn is enable)

Thank you

[gkueny]

@freeboub

btw, in 'normal' exoplayer integration, the flag is removed when the playback is paused...

Yes, that's my understanding and that's how I implement it. When you pause the video in fullscreen, keepScreenOn is removed & screen will go off

Please double check following use case:

• when you pause player, the flag is removed (ie, keepScreenOn is disabled)
• when you player full screen while you are pause and then start playback, the flag shall be enable once playback is started (ie, >keepScreenOn is enable)

I double-checked and it works fine.

[gkueny]

@freeboub Did you have time to look this PR ?

if you have any other questions on the fix implemented, let me know.

[freeboub]

Thank you for the quick integration ! let's merge now !