Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase functionality of component ref #3352

Open
KrzysztofMoch opened this issue Nov 16, 2023 · 11 comments · May be fixed by #3624
Open

Increase functionality of component ref #3352

KrzysztofMoch opened this issue Nov 16, 2023 · 11 comments · May be fixed by #3624
Labels

Comments

@KrzysztofMoch
Copy link
Collaborator

Feature Request

Add functions to component ref to increase functionality of it

  • A method to get the current playback position (time).
  • A method to change the playback rate.
  • A method to change the audio pan direction.
  • A method to check if the video is a livestream or not.
  • A method to control the volume/mute the video.
  • A method to control/get the target latency.
  • A method to get the live latency.

Why it is needed

This will increase developer experience

@alperpacin
Copy link

alperpacin commented Dec 25, 2023

I second that. A method to control the volume/mute the video would be nice since setNativeProps is gone with @6.0.0-alpha.9.

export interface VideoRef {
  seek: (time: number, tolerance?: number) => void;
  resume: () => void;
  pause: () => void;
  presentFullscreenPlayer: () => void;
  dismissFullscreenPlayer: () => void;
  restoreUserInterfaceForPictureInPictureStopCompleted: (
    restore: boolean,
  ) => void;
  save: (options: object) => Promise<VideoSaveData>;
}

@JustJoostNL
Copy link

JustJoostNL commented Feb 17, 2024

@KrzysztofMoch

Hey,
Will this be added soon? This is game changing for our use case.

We'd basically like all methods from here, but if this feature gets prioritized, these should be done first:

  • Play/pause
  • get status
  • set rate
  • set volume/muted
  • onPlaybackStatusUpdate

@alperpacin
Copy link

Any updates on this matter?

@KrzysztofMoch
Copy link
Collaborator Author

Hey, I'm on vacation until the end of the week, I'll see what I can do when I get back

@danielmark0116
Copy link

If there's a space, I could take this one and add these methods! 😎

@JustJoostNL
Copy link

@danielmark0116 that would be amazing!

@JustJoostNL
Copy link

@danielmark0116 any updates on this? 😄

@danielmark0116
Copy link

In the making! Aiming to finish it soon 🚀

@JustJoostNL
Copy link

Sick!

@danielmark0116 danielmark0116 linked a pull request Mar 28, 2024 that will close this issue
@nikonhub
Copy link

nikonhub commented Apr 1, 2024

Wha'ts the reason the remove "setNativeProps" ? I used it to unset the src to limit the memory usage in an infinite list.

@KrzysztofMoch
Copy link
Collaborator Author

I have an issue with it to work in Interop Layer & it's deprecated so I have decided to remove it - but if it will work for you, you are free to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants