Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: vertical videos (tall native aspect ratio) are displayed incorrectly #948

Closed
sunweiyang opened this issue Feb 23, 2018 · 4 comments

Comments

@sunweiyang
Copy link

sunweiyang commented Feb 23, 2018

I'm seeing this for both the default react-native-video (Android’s MediaPlayer API) and react-native-video-exoplayer (even with PR #842 -- I still see this issue).

For tall native aspect ratio videos (height > width, .mp4 files in my case), Android seems to transform my video (height becomes width, width becomes height, pixels are remapped to look like it's rotated). This happens with all resizeMode settings and all style sizes (I happen to have a full screen component in my screenshots, but it consistently happens regardless of component sizes).

This library works perfectly fine for wide native aspect ratio videos (width > height).

Screenshot of Android API 26 (Pixel) showing this problem:
screenshot_1519349292

Screenshot of iOS 11.2 (iPhone SE) with no issues:
simulator screen shot - iphone se - 2018-02-22 at 17 28 15

@sunweiyang sunweiyang changed the title Android: vertical videos (tall native aspect ratio) is displayed incorrectly Android: vertical videos (tall native aspect ratio) are displayed incorrectly Feb 23, 2018
@sunweiyang
Copy link
Author

Some more background: this issue happens for an emulator of Android API 26 (Pixel).
It worked for the one physical Android device I have, which is Android API 24 (Samsung Galaxy S6).

@cobarx
Copy link
Contributor

cobarx commented Jun 9, 2018

Any chance you can provide a video that doesn't work. I've tested:
http://www.exit109.com/~dnn/clips/RW20seconds_1.mp4
and it's working properly on an API 26 emulator.

We recently updated from ExoPlayer 2.4.0 to 2.7.3 and before merging a fix, I want to make sure there's still a problem. Plus I need to test to make sure the fix works :)

@sunweiyang
Copy link
Author

Looks like it works now with the latest exoplayer -- thank you!

@Rotemy
Copy link

Rotemy commented Jul 19, 2020

This is not working with 4.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants