Android support #103

isair · 2015-11-02T23:10:50Z

Add Android support.
Update README.
Update example project.

Closes #91, fixes #94.

- Newer syntax. - Removed lodash dependency. - Removed hard-coded ref. - Seek using state.

Remove seek from state.

rate won't be supported on Android for a while as the native MediaPlayer class doesn't support it either.

jforaker · 2015-11-14T03:30:56Z

@isair could you provide a gist or readme on installation instructions? I recognize the risk on my end, but i would be eternally grateful as time is of the essence and i really need this :)

isair · 2015-11-14T08:04:21Z

@jforaker You need to make additions to 3 files in your react-native project.

android/settings.gradle

include ':RCTVideo', ':app'
project(':RCTVideo').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-video/android')

android/app/build.gradle

dependencies {
   ...
   compile project(':RCTVideo')
}

MainActivity.java

On top, where imports are:

import com.brentvatne.react.ReactVideoPackage;

Under .addPackage(new MainReactPackage()):

.addPackage(new ReactVideoPackage())

jforaker · 2015-11-14T18:56:59Z

Thanks!

Howerver, I think you forgot ReactVideoView in your package.json. I fixed that, however i get red death screen error on run:

Requiring unknown module "keymirror"

I did npm install keymirror and that did not help. Ideas?

jforaker · 2015-11-17T01:01:53Z

@isair After testing a few times, few different configs, the video does not play, and i keep getting this error in Android Studio (no errors in chrome):

11-16 19:53:44.255 2415-2415/com.crashr_react_native W/ResourceType: No package identifier when getting value for resource number 0x00000000
11-16 19:53:44.255 2415-2415/com.crashr_react_native W/System.err: android.content.res.Resources$NotFoundException: Resource ID #0x0
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.content.res.Resources.getValue(Resources.java:1266)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.content.res.Resources.openRawResourceFd(Resources.java:1224)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.yqritc.scalablevideoview.ScalableVideoView.setRawData(ScalableVideoView.java:121)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.brentvatne.react.ReactVideoView.setSrc(ReactVideoView.java:119)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.brentvatne.react.ReactVideoViewManager.setSrc(ReactVideoViewManager.java:66)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at java.lang.reflect.Method.invoke(Method.java:372)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.ViewManagersPropertyCache$MapPropSetter.updateProperty(ViewManagersPropertyCache.java:175)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateProp(ViewManagersPropertyCache.java:63)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:47)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.NativeViewHierarchyManager.createView(NativeViewHierarchyManager.java:182)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation.execute(UIViewOperationQueue.java:137)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:574)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:622)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.GuardedChoreographerFrameCallback.doFrame(GuardedChoreographerFrameCallback.java:32)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.facebook.react.uimanager.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:114)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.view.Choreographer$CallbackRecord.run(Choreographer.java:765)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.view.Choreographer.doCallbacks(Choreographer.java:580)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.view.Choreographer.doFrame(Choreographer.java:549)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.os.Handler.handleCallback(Handler.java:739)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.os.Handler.dispatchMessage(Handler.java:95)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.os.Looper.loop(Looper.java:135)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:5254)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at java.lang.reflect.Method.invoke(Native Method)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at java.lang.reflect.Method.invoke(Method.java:372)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
11-16 19:53:44.259 2415-2415/com.crashr_react_native W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

I have the "broadchurch.mp4" in the same directory as my video component, calling it like this:

    <Video source={{uri: 'broadchurch'}}
           style={styles.fullScreen}
           rate={this.state.rate}
           paused={this.state.paused}
           volume={this.state.volume}
           muted={this.state.muted}
           resizeMode={this.state.resizeMode}
           onLoad={this.onLoad}
           onProgress={this.onProgress}
           repeat={false}/>

Does it work for you? Am I setting the source incorrectly? (tried new source={require('./my-icon.png')} style syntax and that threw a red screen error)

isair · 2015-11-17T01:04:52Z

@jforaker Try putting your video file in your Android raw sources folder.

jforaker · 2015-11-17T01:59:40Z

Ok I tried all of these:
<Video source={{uri: './android/app/src/main/assets/broadchurch'}}
<Video source={{uri: './android/app/src/main/assets/broadchurch.mp4'}}
<Video source={{uri: 'android/app/src/main/assets/broadchurch'}}
<Video source={{uri: 'android/app/src/main/assets/broadchurch.mp4'}}

and get the same error

11-16 20:58:03.066 21349-21349/com.crashr_react_native W/System.err: android.content.res.Resources$NotFoundException: Resource ID #0x0

Also tried a youtube source and get this:

11-16 20:53:26.010 19736-19736/com.crashr_react_native W/MediaPlayer: setScreenOnWhilePlaying(true) is ineffective without a SurfaceHolder
11-16 20:53:26.024 2551-15396/? D/NuPlayerDriver: reset(0xf10cfae0)
11-16 20:53:26.024 2551-15396/? D/NuPlayerDriver: notifyListener_l(0xf10cfae0), (1, 0, 0)
11-16 20:53:26.024 2551-15396/? D/NuPlayerDriver: notifyListener_l(0xf10cfae0), (8, 0, 0)
11-16 20:53:26.024 2551-20102/? D/NuPlayerDriver: notifyResetComplete(0xf10cfae0)
11-16 20:53:26.025 2551-4928/? D/NuPlayerDriver: reset(0xf10cfae0)
11-16 20:53:26.041 19736-19736/com.crashr_react_native W/MediaPlayer: setScreenOnWhilePlaying(true) is ineffective for Surface
11-16 20:53:26.041 2551-20107/? D/NuPlayer: onSetVideoSurface(0xee403500, no video decoder)
11-16 20:53:26.990 2551-20126/? I/NuCachedSource2: caching reached eos.
11-16 20:53:27.003 2551-20127/? E/NuCachedSource2: source returned error -1, 10 retries left
11-16 20:53:27.027 2551-20108/? E/GenericSource: Failed to init from data source!
11-16 20:53:27.028 2551-20107/? D/NuPlayerDriver: notifyListener_l(0xf10d0260), (100, 1, -2147483648)
11-16 20:53:27.028 19736-20106/com.crashr_react_native E/MediaPlayer: error (1, -2147483648)
11-16 20:53:27.032 19736-19736/com.crashr_react_native E/MediaPlayer: Error (1,-2147483648)
11-16 20:53:28.865 3674-12188/? D/NetlinkSocketObserver: NeighborEvent{elapsedMs=539731960, 192.168.0.1, [407009528617], RTM_NEWNEIGH, NUD_STALE}
11-16 20:53:30.272 2551-20127/? I/NuCachedSource2: retrying a previously failed read succeeded.
11-16 20:53:30.276 2551-20127/? I/NuCachedSource2: caching reached eos.
11-16 20:53:30.282 2551-20103/? E/GenericSource: Failed to init from data source!
11-16 20:53:30.290 2551-20103/? W/AMessage: failed to post message as target looper for handler 0 is gone.

isair · 2015-11-17T02:01:03Z

<Video source={{uri: 'broadchurch'}} /> is fine. Just put that mp4 file in android/app/src/main/res/raw/.

jforaker · 2015-11-17T02:04:34Z

BOOM goes the dynamite! There it is!! 👍 thank you

jforaker · 2015-11-17T02:16:42Z

Be sure to make a note in the install docs:

Error: 'G' is not a valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
111

aka filename must only contain lowercase a-z, 0-9, or underscore

isair · 2015-11-18T23:17:42Z

@jforaker Will keep in mind, cheers!

isair · 2015-11-20T21:24:39Z

Reviewed 8 of 11 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

brentvatne · 2015-11-21T02:01:48Z

😍

jforaker · 2015-12-06T22:25:43Z

@isair it seems to be broken in 0.16.0 (was working flawlessly in 0.15 and under). Possibly related to facebook/react-native#4605 < check it out

brentvatne · 2015-12-07T06:34:23Z

@isair - this is working great so far! @jforaker - submitted a PR upstream to fix this. Also added the example project so I checked that off above. If you want to add the documentation above to the README (follow the steps verbatim and it worked without a hitch) I'm comfortable landing this now if you are!

isair · 2015-12-07T23:54:17Z

@brentvatne Thanks for fixing that issue. I'll update the README and finalize this PR tonight.

brentvatne · 2015-12-08T00:39:39Z

@jforaker - I would argue that @isair rocks more for his awesome work on this branch 🚀 🎸

isair · 2015-12-08T10:46:10Z

Reviewed 26 of 32 files at r3, 1 of 1 files at r4, 2 of 8 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

isair · 2015-12-08T10:48:06Z

@brentvatne Haha, my pleasure.

rclai · 2015-12-09T18:42:56Z

Whoa, this looks awesome. Is this about to get merged today?

eranbes · 2015-12-11T14:56:38Z

Yes, merge merge merge :-)

Android support

isair added 5 commits October 29, 2015 17:39

[Video] Tidy up component code

b45c957

- Newer syntax. - Removed lodash dependency. - Removed hard-coded ref. - Seek using state.

[Video] Method location rearrangement

8262180

[Android] Initial commit

0a3fdd9

[npm] Add android files to package

318ce5d

[npm][Android] Include RCTVideo.iml

f34bd9d

isair force-pushed the feature/android-support branch from 1d378ae to 0de0ed0 Compare November 2, 2015 23:35

[npm] Typo fix

1746779

isair force-pushed the feature/android-support branch from 0de0ed0 to 1746779 Compare November 2, 2015 23:37

isair added 13 commits November 3, 2015 20:27

[Android] src, repeat, paused properties fully working

4362e59

[Android] repeat, muted, volume properties fully working

c03c45a

[Android] Send onVideoLoadStart, onVideoLoad, and onVideoEnd events

8679034

[Android] Better code structure

d174b1a

[Video] Implement setNativeProps

63a860e

[Video] Bind missing callbacks

125b99d

Remove seek from state.

[Android] Move events inside RCTVideoView

9e9e45c

[Android] Fix video events

44203ab

[Android] Prepare media player asynchronously

e63a004

[Android] Default prop values

6ddd157

[Android] Fix MediaPlayer issues

9f73f22

[Android] Implement seek and rate properties

a52f1d5

rate won't be supported on Android for a while as the native MediaPlayer class doesn't support it either.

[Android] Simplify src assignment

93b426c

[Video] Define style in propTypes

804717e

brentvatne added 3 commits December 6, 2015 22:02

Update example project to v0.16.0-rc

ce29c1f

Add Android VideoPlayer example

fde97eb

Remove alert on Android example

5f6f1c3

Fix for issue #4605 on react-native

10f7690

isair added 2 commits December 8, 2015 02:37

[README] Add Android installation instructions

dc81b80

[git] Ignore .gradle/

ff40eb7

isair changed the title ~~[WIP] Android support~~ Android support Dec 8, 2015

isair assigned brentvatne Dec 8, 2015

isair assigned isair and unassigned brentvatne Dec 12, 2015

isair added a commit that referenced this pull request Dec 12, 2015

Merge pull request #103 from brentvatne/feature/android-support

f4c3e14

Android support

isair merged commit f4c3e14 into master Dec 12, 2015

isair deleted the feature/android-support branch December 12, 2015 00:13

ghost mentioned this pull request Aug 15, 2016

[Android] Playing local files #125

Closed

ghost mentioned this pull request Mar 15, 2017

fix(RCTVideo.m): Fixed status bar disappearing issue #532

Merged

HessiPard mentioned this pull request Jan 6, 2020

Unable to load videos from Android Assets folder #1826

Closed

This was referenced Aug 23, 2022

Android asset does not play #2096

Closed

Read the video from android asset folder #2825

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android support #103

Android support #103

isair commented Nov 2, 2015

jforaker commented Nov 14, 2015

isair commented Nov 14, 2015

jforaker commented Nov 14, 2015

jforaker commented Nov 17, 2015

isair commented Nov 17, 2015

jforaker commented Nov 17, 2015

isair commented Nov 17, 2015

jforaker commented Nov 17, 2015

jforaker commented Nov 17, 2015

isair commented Nov 18, 2015

isair commented Nov 20, 2015

brentvatne commented Nov 21, 2015

jforaker commented Dec 6, 2015

brentvatne commented Dec 7, 2015

isair commented Dec 7, 2015

brentvatne commented Dec 8, 2015

isair commented Dec 8, 2015

isair commented Dec 8, 2015

rclai commented Dec 9, 2015

eranbes commented Dec 11, 2015

Android support #103

Android support #103

Conversation

isair commented Nov 2, 2015

jforaker commented Nov 14, 2015

isair commented Nov 14, 2015

android/settings.gradle

android/app/build.gradle

MainActivity.java

jforaker commented Nov 14, 2015

jforaker commented Nov 17, 2015

isair commented Nov 17, 2015

jforaker commented Nov 17, 2015

isair commented Nov 17, 2015

jforaker commented Nov 17, 2015

jforaker commented Nov 17, 2015

isair commented Nov 18, 2015

isair commented Nov 20, 2015

brentvatne commented Nov 21, 2015

jforaker commented Dec 6, 2015

brentvatne commented Dec 7, 2015

isair commented Dec 7, 2015

brentvatne commented Dec 8, 2015

isair commented Dec 8, 2015

isair commented Dec 8, 2015

rclai commented Dec 9, 2015

eranbes commented Dec 11, 2015