Fix android build errors with RN 0.71 #684
Open
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saghul please review this |
|
Sorry I'm not familiar enough with this project to give a proper review. Personally, bumping the minimum SDK to 27 sounds like it would leave too many users out. |
- Add redundant handling for missing permission exceptions. Existing checks work but do not satisfy lint, so this is the only way to resolve react-native-webrtc#646 - Upgrade gradle to maximum compatible version (3.6.4) to satisfy new minimum (3.2.0) - Use AudioManager.MODE_NORMAL constant explicitly (instead of the equivalent value of "0" currently being used) to satisfy lint - Replace deprecated WindowManager.LayoutParams constants with Activity API methods when using Android SDK v27+
|
@manuquentin I've updated the PR to maintain compatibility with older platform versions. |
|
@manuquentin Can you please advise if there any further changes you would like to get this merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to React Native 0.71, we are getting build failures on Android (including #646).
This PR makes the following changes to resolve these:
Add redundant handling for missing permission exceptions. Existing checks work but
do not satisfy lint, so this is the only way to resolve Call requires permission which may be rejected by user #646
Upgrade gradle to maximum compatible version (3.6.4) to satisfy new minimum (3.2.0)
Use AudioManager.MODE_NORMAL constant explicitly (instead of the equivalent value of
"0" currently being used) to satisfy lint
Replace deprecated WindowManager.LayoutParams constants with Activity API methods
when using Android SDK v27+