Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused imports #74

Closed
Romick2005 opened this issue Dec 8, 2020 · 1 comment
Closed

Unused imports #74

Romick2005 opened this issue Dec 8, 2020 · 1 comment

Comments

@Romick2005
Copy link
Contributor

Romick2005 commented Dec 8, 2020 •
edited
Loading

Hi @zxcpoiu, great job on the voip push notifications!
I have a small question. While I was inspecting your code I noticed that there are unused imports:
#import <React/RCTConvert.h>
#import <React/RCTUtils>
I am new to Objective-C so I cannot be 100% sure about this. So if they are really unneeded, should I fire a PR for that or you will just adjust that in next release?
@zxcpoiu
Copy link
Member

zxcpoiu commented Dec 9, 2020

I was refer to some boilerplate somewhere, if you removed the two import and everything are build and work as usual, it's welcome to fire a PR then 👍

zxcpoiu added a commit to zxcpoiu/react-native-voip-push-notification that referenced this issue Jan 15, 2021
@zxcpoiu
remove unused import
7532850 
close react-native-webrtc#74 thanks to @Romick2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zxcpoiu @Romick2005