Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_delayedEvents multiple initialisation #86

Closed
Romick2005 opened this issue May 12, 2021 · 1 comment
Closed

_delayedEvents multiple initialisation #86

Romick2005 opened this issue May 12, 2021 · 1 comment

Comments

@Romick2005
Copy link
Contributor

I noticed that RNVoipPushNotificationManager class is not a real singletone that is why it is initialised multiple times.
Also on metro bundler reload there in no way to get lastVoipToken
Romick2005 added a commit to Romick2005/react-native-voip-push-notification that referenced this issue May 12, 2021
@Romick2005
react-native-webrtc#86 Fix singletone class initialisation. Handle bu…
afb3b11 
…ndle stob start observing issue.
Romick2005 added a commit to Romick2005/react-native-voip-push-notification that referenced this issue May 19, 2021
@Romick2005
react-native-webrtc#86 Applying review changes.
27a1107
Romick2005 added a commit to Romick2005/react-native-voip-push-notification that referenced this issue May 19, 2021
@Romick2005
react-native-webrtc#86 Applying review changes.
b88f6f8
zxcpoiu pushed a commit that referenced this issue May 19, 2021
@Romick2005
#86 Fix singletone class initialisation (#87)
c299bae
@zxcpoiu
Copy link
Member

zxcpoiu commented May 19, 2021

closed by #87

@zxcpoiu zxcpoiu closed this as completed May 19, 2021
zxcpoiu added a commit that referenced this issue May 20, 2021
@zxcpoiu
release 3.3.0
452dc9c 
3e7f1a8 misc: normalize package.json  ( zxcpoiu 2021-05-20 01:50:13 -0700)
c299bae #86 Fix singletone class initialisation (#87)  ( Romick2005 2021-05-19 11:37:06 +0300)
54356e0 release 3.2.0  ( zxcpoiu 2021-04-17 02:12:48 +0800)
99feae8 feat: add typescript support  ( dayze 2021-02-23 11:36:48 +0100)
zxcpoiu pushed a commit that referenced this issue Dec 5, 2022
@Romick2005
Fix stopObserving on reload issue (#89)
8a1ba71 
* #86 Fix singletone class initialisation.  Handle bundle stob start observing issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zxcpoiu @Romick2005