-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS] PeerConnection not found on IOS when Android and Web work #1453
Comments
The shim is not update and there are problems with it at this time. That might be it. |
Yeah I saw there was some issues with the shim, but if it's working in web and android i assumed the shim wouldn't override anything that wasn't web, and with android working I assumed the shim was fine? That said I did try it without the shim and was facing the same error. |
I tried something other than
|
It's very unusual for PC creation to fail. Do you see anything in the WebRTC logs? |
I found the problem about the iceServers, modified it's then it's working now, But I still do not know why android work |
Can show how you modified them so we can try to reproduce the problem? |
Here is before :
After fix:
|
Can you please print the iceServers list when it fails? |
when it's failed the iceServer = [], I am sure only change iceServer to
and remove those code
that solved my problem |
So an empty array of ICE servers caused it? I'll take a look! |
Very unusual 🤔 |
I have found something. If converting the ObjC / Java RTCConfiguration to native fails, the returned PC is null. I'll throw an exception right there and then, since otherwise the error would be masked. |
It should usually only trigger for bugs in the library, but things will break in very weird ways otherwise. Ref: #1453
I created #1454 to given an error if we fail to create the PC. However, I could not reproduce the crash by creating the PC like so:
See: ![]() What is the minimal repro case for this? A cursory look at how we process ICE servers makes it seem correct to me. |
It should usually only trigger for bugs in the library, but things will break in very weird ways otherwise. Ref: #1453
I am using WebRTC in a less than normal manner. I use it alongside Janus to stream a video feed to my application, this is a one way stream, the client will only ever recieve video, no audio.
I have integrated
janus.js
and this library to get my stream appearing. It works fine on Web and Android, but on iOS an error is thrown shortly afterI have tried debugging this problem but can't see where the issue is (especially when the
janus.js
library is unbeliebably unreadable)My knowledge of WebRTC isn't great which may be why I am facing this issue! It might be to the point where I need to write my own library for
janus.js
as it can be a little tricky to get it to interface correctly (But I can't see the Janus code being platform dependant).I have attached the logs below.
I also get this message on the simulator (sorry to paste text in an image, couldn't find how to copy)
![image](https://private-user-images.githubusercontent.com/25775112/272008611-155a4a1e-b357-4e56-be6e-a779bb694973.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MTAxMTYsIm5iZiI6MTcxOTQwOTgxNiwicGF0aCI6Ii8yNTc3NTExMi8yNzIwMDg2MTEtMTU1YTRhMWUtYjM1Ny00ZTU2LWJlNmUtYTc3OWJiNjk0OTczLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDEzNTAxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwZDljM2ZmZDY3MzZlZDI1ZmM5N2UxZDFhNGIzOTJiMjc1NzdmNjY0NWIzNDM4MzYzZGY4MWYzOTRlZTBhMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oS51xeEDRtO6Nlf5KnDStE2rl4MGLX_QmwoK5V1Ya6c)
Like mentioned above, stream is working fine on Android and Web.
Platform Information
To note, I am also using
react-native-webrtc-web-shim@1.0.3
The text was updated successfully, but these errors were encountered: