New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple video frame processors (+ implementation for ios) #1331
base: master
Are you sure you want to change the base?
Conversation
107106d
to
7997834
Compare
Thank you! I'll provide a full review as soon as possible. Quick question: what is your use case, that needs multiple processors at once? |
With multiple processors, users will be able to pipe the processors in order. For example, in future I want to apply beauty face effect first, then apply virtual background effect. |
Makes sense! |
This comment was marked as outdated.
This comment was marked as outdated.
hi @wjaykim can u provide sample processor like virtual background, blur... thanks so much |
Sorry for late response. I pushed the conflicts resolved code. |
Thanks for resolving the conflicts. Old Rotate Effect Implementation Ref: #1169 |
Will need a review and testing but possibly good to go for the next release 🤔 |
Hoping to test iOS soon but Android support seems to be working as expected. |
I'd like to wait until 118 is done. |
No worries, gives extra time to test 😸 |
Greetings. Could you tell me how I can test the video effects from this PR? I'm interested in any effect that can be applied to the stream, for example, a background blur, a simple geometric figure on top of the stream, etc. Thank you in advance. |
Sorry for the overly late response. |
This PR adds support for registering multiple video frame processors.
Plus, it adds missing video frame processor functionality for ios platform as well.