Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple video frame processors (+ implementation for ios) #1331

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wjaykim
Copy link
Contributor

@wjaykim wjaykim commented Feb 22, 2023

This PR adds support for registering multiple video frame processors.
Plus, it adds missing video frame processor functionality for ios platform as well.

@saghul
Copy link
Member

saghul commented Feb 22, 2023

Thank you! I'll provide a full review as soon as possible.

Quick question: what is your use case, that needs multiple processors at once?

@wjaykim
Copy link
Contributor Author

wjaykim commented Feb 22, 2023

With multiple processors, users will be able to pipe the processors in order. For example, in future I want to apply beauty face effect first, then apply virtual background effect.
Also it is possible to apply the effects in one processor by writing all the codes in a processor, but then I won't be able to disable one of either effect if user want to disable one of those effects.

@saghul
Copy link
Member

saghul commented Feb 22, 2023

Makes sense!

@8BallBomBom 8BallBomBom added enhancement Enhancement of an existing feature waiting-response Waiting for a response from the contributor or reviewer labels Apr 4, 2023
@8BallBomBom

This comment was marked as outdated.

@stale stale bot added the wontfix There are no plans to work on this label Jun 8, 2023
@8BallBomBom 8BallBomBom removed the wontfix There are no plans to work on this label Jun 8, 2023
@fukemy
Copy link

fukemy commented Jun 15, 2023

hi @wjaykim can u provide sample processor like virtual background, blur... thanks so much

@wjaykim
Copy link
Contributor Author

wjaykim commented Jun 19, 2023

Sorry for late response. I pushed the conflicts resolved code.

@react-native-webrtc react-native-webrtc deleted a comment from stale bot Jul 25, 2023
@8BallBomBom
Copy link
Member

8BallBomBom commented Jul 25, 2023

Thanks for resolving the conflicts.
Will be looking to test and merge soon.


Old Rotate Effect Implementation Ref: #1169

@8BallBomBom 8BallBomBom added needs-testing Testing is required documentation Improvements or additions to documentation and removed waiting-response Waiting for a response from the contributor or reviewer labels Jul 25, 2023
@8BallBomBom
Copy link
Member

Will need a review and testing but possibly good to go for the next release 🤔
Should bring Android and iOS up to feature parity for the frame processor/effect handling.

@8BallBomBom 8BallBomBom added the confirmed The issue has been confirmed label Sep 19, 2023
@8BallBomBom
Copy link
Member

Hoping to test iOS soon but Android support seems to be working as expected.
@saghul Think we can include this with the next release or alongside M118?

@saghul
Copy link
Member

saghul commented Nov 13, 2023

I'd like to wait until 118 is done.

@8BallBomBom
Copy link
Member

No worries, gives extra time to test 😸

@QSJSI
Copy link

QSJSI commented Dec 6, 2023

Hoping to test iOS soon but Android support seems to be working as expected. @saghul Think we can include this with the next release or alongside M118?

Greetings. Could you tell me how I can test the video effects from this PR? I'm interested in any effect that can be applied to the stream, for example, a background blur, a simple geometric figure on top of the stream, etc. Thank you in advance.

@8BallBomBom @wjaykim

@8BallBomBom
Copy link
Member

8BallBomBom commented Apr 30, 2024

Sorry for the overly late response.
We may include examples in the future.
As for this PR, I'll be looking to push it up soon with the New Arch update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The issue has been confirmed documentation Improvements or additions to documentation enhancement Enhancement of an existing feature needs-testing Testing is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants