New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios,android: setCodecPreferences and getCapabilities #1392
Conversation
This is looking really good. I reckon we can cherry pick the upstream patches once iOS lands and release 114 or 115. |
FYI I pulled your patch into the JitsiWebRTC build and put this patch in the M118 PR: #1462 |
Seems the Android patch was merged upstream but the iOS patch was reversed over here. |
I merged the patch in JitsiWebRTC, I'm tired of waiting for months for such a trivial change. |
Understandable but as they reverted the iOS patch on the main WebRTC repo due to something breaking, thought maybe we might need to investigate even with things being upstreamed in JitsiWebRTC 🤔 Otherwise we can close this? |
We can close this because I integrated it in the M118 PR. I'm following up upstream (we have a reland CL) because that breakage is nonesense. |
Alrighty, just had to be sure 😸 |
Related upstream patches:
ios: https://webrtc-review.googlesource.com/c/src/+/305200
android: https://webrtc-review.googlesource.com/c/src/+/304880
Not sure when the objc will land and when we can upgrade to it, but posting this PR in advance.