Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios,android: setCodecPreferences and getCapabilities #1392

Closed
wants to merge 4 commits into from

Conversation

davidliu
Copy link
Collaborator

@davidliu davidliu commented Jun 7, 2023

Related upstream patches:

ios: https://webrtc-review.googlesource.com/c/src/+/305200

android: https://webrtc-review.googlesource.com/c/src/+/304880

Not sure when the objc will land and when we can upgrade to it, but posting this PR in advance.

@davidliu davidliu marked this pull request as draft June 7, 2023 16:20
@saghul
Copy link
Member

saghul commented Jun 7, 2023

This is looking really good. I reckon we can cherry pick the upstream patches once iOS lands and release 114 or 115.

@8BallBomBom 8BallBomBom added the enhancement Enhancement of an existing feature label Jul 20, 2023
@stale stale bot added the wontfix There are no plans to work on this label Sep 19, 2023
@react-native-webrtc react-native-webrtc deleted a comment from stale bot Sep 19, 2023
@8BallBomBom 8BallBomBom added confirmed The issue has been confirmed upstream Work is required upstream and removed wontfix There are no plans to work on this labels Sep 19, 2023
@saghul
Copy link
Member

saghul commented Oct 17, 2023

FYI I pulled your patch into the JitsiWebRTC build and put this patch in the M118 PR: #1462

@8BallBomBom
Copy link
Member

8BallBomBom commented Nov 13, 2023

Seems the Android patch was merged upstream but the iOS patch was reversed over here.
Was going to close this as things have been merged with the M118 pr.
But leaving open as the iOS patch is unresolved 🤔

@saghul
Copy link
Member

saghul commented Nov 13, 2023

I merged the patch in JitsiWebRTC, I'm tired of waiting for months for such a trivial change.

@8BallBomBom
Copy link
Member

8BallBomBom commented Nov 13, 2023

Understandable but as they reverted the iOS patch on the main WebRTC repo due to something breaking, thought maybe we might need to investigate even with things being upstreamed in JitsiWebRTC 🤔

Otherwise we can close this?

@saghul
Copy link
Member

saghul commented Nov 13, 2023

We can close this because I integrated it in the M118 PR. I'm following up upstream (we have a reland CL) because that breakage is nonesense.

@8BallBomBom
Copy link
Member

Alrighty, just had to be sure 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The issue has been confirmed enhancement Enhancement of an existing feature upstream Work is required upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants