-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIGRATED: App crashes on startup on select environments (Samsung + Android 7 + outdated system WebView) (#18322) #14
Comments
This comment has been minimized.
This comment has been minimized.
support multiple window to create new tab
This is currently out of our control. Closing for now, however if a fix is discovered please let us know when a reproduction/PR and we'll investigate further 👍 |
Shouldn't this be as simple as adding a check for |
Looks like this crash is back (or was never resolved). Any ideas? |
1 similar comment
Looks like this crash is back (or was never resolved). Any ideas? |
It's happening to my app too. Any workaround ? |
…bView in view hierarchy * add support to reuse instance with webViewKey * change up * address comments related to layout params * add nullability checks * fix * get full stack trace * add secondary map * rename to ifHasInternalWebView * additional fixes * fix * fix boolean [android] add messaging passing without a react tag (react-native-webview#12) This PR adds messaging passing. This was much simpler to do than the iOS counter part. This is the analogue to the following PR: discord#6. I've followed the same test plan. The sample app was really nice to use when testing. In the previous PR discord#11, I broke all native->react-native communication since events were being passed by the `InternalWebView` viewId not the `RNCWebView` viewId. This is now fixed. [android] check source prop if changed (react-native-webview#14) * [android] check source prop if changed * detect if new source is null too
I also just got a crashlytics report about this. (using react-native)
|
MIgrated from facebook/react-native#18322
@semekh says:
We were seeing a notable amount of crashes on Samsung devices, and after getting hold of a device that kept crashing, we realized that even a freshly react-native inited project crashes on startup.
Environment
Environment:
OS: Linux 4.15
Node: 9.8.0
Yarn: 1.5.1
npm: 5.7.1
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: 0.54.1 => 0.54.1
According to our crash reporter, the crash is limited to Samsung devices running Android 7.0.0.
On these devices, "Android WebView Implementation" is installed with version 0.0.0.1 which looks suspicious.
Workaround
Updating Android WebView Implementation from Play Store fixes the issue.
Stacktrace
More info on original issue thread
The text was updated successfully, but these errors were encountered: