-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin with id 'kotlin-android' not found - fixed #1407
Comments
came here to add this issue. |
To Reproduce: 1: Task failed with an exception.
2: Task failed with an exception.
|
I added in
That helped but I waiting guide from maintainers. EDIT FROM MAINTAINER: this won't be required in versions > 10.1.0, you might want to remove it if you don't wanna risk importing 2 different versions for no reason. |
Same issue. |
Same issue |
Same issue, no luck with @Bardiamist comment. |
Most likely broken by #1230 |
Same issue |
Yes, effectively reverting #1230 by replacing node_modules/react-native-webview/android/build.gradle with the file before the change (https://raw.githubusercontent.com/react-native-community/react-native-webview/e6241cbb6aba6e98b2e0a82011ec0aabaca854b3/android/build.gradle) fixes things You can use the ever-impressive / always-useful patch-package (https://github.com/ds300/patch-package) to persist the change after you've reverted locally in order to move forward @Titozzz / @SaeedZhiany -> #1230 needs a revert 🙏 |
Thanks for the report, it's 2AM here, but I'll look into it first thing tomorrow, until then please use V9 |
Here's a patch-package patch in case anyone wants to stick on v10.x - seems fine otherwise I tried this exact transform myself (for this module) to conditional gradle inclusion after working on it with @SaeedZhiany in some of the related issues and in the modules I maintain - it's a standard thing that works 100% of the time...except for kotlin and I couldn't figure out why. Until someone does this will be the one module where it doesn't work I suppose but I'm not anti-kotlin - it's just an interoperability thing to figure out. Cheers |
I guess the problem is your root projects do not use kotlin Gradle plugin and so the plugin does not loaded on building time and cause error. I can't test it my self right now but I have two solutions in my mind.
However, reverting the PR changes completely is not best solution, we all know what is the side effects. |
@SaeedZhiany For now I'm gonna make sure we download kotlin for all users, so that's it's not breaking nor requiring changes on their codebases, but I agree we can prob find a better solution so that if you already have kotlin it does not import it. This will come later as this is pretty urgent |
🎉 This issue has been resolved in version 10.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Titozzz |
@SaeedZhiany We don't want users to have any native step to perform when installing the library |
The correct solution is to push a patch upstream in react-native @SaeedZhiany that gets kotlin into people's root projects, then webview can do it, IMHO |
I agree with your suggestion, but there are a few RN modules using kotlin in their library, so maybe it's hard right now to convince RN maintainers to put that config in the RN template. (I couldn't convince them yet about putting androidx packages' version in root project if you remember about that) |
Do it impact users not using Kotlin if we add the dep? |
@SaeedZhiany hard nevertheless the correct step. Until then @Titozzz I think waiting to merge the currently-reverted PR is the correct action as it removes all user onboarding kotlin work from the module. This is just my opinion but it's tilted heavily towards preserving limited maintainer time from support requests and developer time from needing to do work for an upgrade or initial module integration, both things I'm passionate about. Upstream went with Swift for 0.62, Maybe it's time for Kotlin in 0.64. If you raise a PR there and tag me I will voice my support and cross-reference this with brief explanation to substantiate |
@Titozzz yes - if people are not using kotlin directly in their project, and if this is their only kotlin-using module, then with the dep in this module's build.gradle it brings in kotlin where otherwise it wouldn't. But that's android development. Kotlin is a first class citizen, bringing it in is the same as when a cocoapod is using Swift or Flipper uses Swift (that's iOS development, it should be handled) |
@mikehardy thanks for the confirmation. |
I used that: buildscript { and Thanks a lot @Bardiamist |
I am currently learning flutter and the run command comes up with the exact same problem.flutter doctor suggests that all depencies are up to date and no issues.was wondering to go about solving this one. |
facing this after above changes |
Same here with react-native-camera-kit |
I had to follow these steps: Change kotlinVersion to kotlin_version Change minSdkVersion 21 to 23 because of the error: Also to:
|
buildscript {
|
nawa o |
same issues... I'm getting an error just react-native-vision-camera and react-native-camera-kit libraries. ı'm try tried adding this kotlin_Version = "1.3.72" but doesn't work. Help me pls |
FIXED in 10.1.1
Thanks all for the report, sorry again 😢
Original report follows:
Bug description:
Cant build project by Android Studio with next error:
To Reproduce:
I just updated
react-native-webview
from9.4.0
to10.1.0
.Expected behavior:
Build project successfully.
Environment:
The text was updated successfully, but these errors were encountered: