Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for UIWebView #2

Closed
jamonholmgren opened this issue Sep 9, 2018 · 3 comments
Closed

Drop support for UIWebView #2

jamonholmgren opened this issue Sep 9, 2018 · 3 comments
Labels
Maintainer: blocked Unable to fix because we are blocked by something

Comments

@jamonholmgren
Copy link
Member

@Titozzz asked me if we could drop support for UIWebView in this package, and I had already mentioned this in the RFC. When testing this package, there are several issues with UIWebView, so it makes sense to drop support for it.

My proposal is to leave UIWebView in (for now) but not put engineering time into it, and in a few versions drop support for UIWebView entirely.
@jamonholmgren jamonholmgren mentioned this issue Sep 9, 2018
Merged
@jamonholmgren
Copy link
Member Author

This package now uses WKWebView by default instead of UIWebView (per #3). I'll leave this issue open, as we'll want to fully drop support for UIWebView at some point.

@Titozzz
Copy link
Collaborator

Titozzz commented Sep 10, 2018

Great 🎉

ankur-sardar referenced this issue in lunascape/react-native-webview Oct 25, 2018
@ankur-sardar
Merge pull request #2 from ankur-sardar/dev-ankur
74711e2 
Set OnLongClick listener in android webview to show Custom Context menu
@jamonholmgren jamonholmgren added Type: feature request New feature or request Maintainer: blocked Unable to fix because we are blocked by something refactor and removed Type: feature request New feature or request labels Dec 21, 2018
ralesiupgrade pushed a commit to ralesiupgrade/react-native-webview that referenced this issue Feb 11, 2019
@manuelblum
Merge pull request react-native-webview#2 from vivid-planet/bugfix-props
40655a7 
Bugfix props
@Titozzz Titozzz mentioned this issue Feb 28, 2019
Closed
RangerMauve pushed a commit to RangerMauve/react-native-webview that referenced this issue Mar 11, 2019
@rbscott
Merge pull request react-native-webview#2 from ccorcos/android-scheme…
2e1134d 
…-listener

Android scheme listener
@Titozzz Titozzz removed the refactor label Mar 20, 2019
@Titozzz
Copy link
Collaborator

Titozzz commented Mar 26, 2019

Dup of #312

@Titozzz Titozzz closed this as completed Mar 26, 2019
@lhh-sofy lhh-sofy mentioned this issue Apr 4, 2019
Closed
fcopardo referenced this issue in Evernote/react-native-webview Oct 5, 2019
@fcopardo
Merge pull request #2 from fcopardo/feature/android_webview_native_co…
f0613ca 
…nfig_androidx

applied the configuration changes to master based branch
@mikedream89 mikedream89 mentioned this issue Dec 30, 2019
Closed
ALashchotka referenced this issue in ALashchotka/react-native-webview Apr 16, 2020
Try #2
781342b
leoyey pushed a commit to leoyey/react-native-webview that referenced this issue Sep 16, 2020
Merge pull request react-native-webview#2 from brunobar79/fix-ios-inj…
3b26c13 
…ection

Allow javascript to be injected onDocumentStart
leoyey pushed a commit to leoyey/react-native-webview that referenced this issue Sep 16, 2020
@danjm
Prevent js injection for non-200 response status codes (react-native-…
aeaf987 
…webview#2)

* Prevent js injection for responses that contain 405 status codes, in shouldInterceptRequest of webviewmanager

* Make injection decision logic more robust: only on succesful responses and when containing some html
@juhasuni juhasuni mentioned this issue Sep 17, 2020
Closed
@jocoders jocoders mentioned this issue Mar 30, 2021
Closed
KalvinMac referenced this issue in D3-Mobile/react-native-webview Oct 28, 2021
Merge pull request #2 from isi-d3/ios-file-download
d210a62 
handle ios file downloads
cou929 added a commit to cou929/react-native-webview that referenced this issue Aug 26, 2022
@cou929
apply part of discord's patch
d553cf7 
* ref. discord#2
* apply above react-native-webview#2 pr into v11.23.0 tag of original master repo
  * react-native-webview#2 was forked from v11.18.1
* removed codes for iOS to avoid to stumble something unexpected
cou929 added a commit to cou929/react-native-webview that referenced this issue Sep 5, 2022
@cou929
apply part of discord's patch
316a1c9 
* ref. discord#2
* apply above react-native-webview#2 pr into v11.23.0 tag of original master repo
  * react-native-webview#2 was forked from v11.18.1
* removed codes for iOS to avoid to stumble something unexpected
@andreialecu andreialecu mentioned this issue Dec 3, 2022
Closed
matias-la pushed a commit to matias-la/react-native-webview that referenced this issue Feb 27, 2023
@timlanahan
Merge pull request react-native-webview#2 from ExodusMovement/tim/rem…
8a0b140 
…ove-windows

chore: remove windows
@shahkaush shahkaush mentioned this issue Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintainer: blocked Unable to fix because we are blocked by something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamonholmgren @Titozzz