Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use menuItems on iOS 16 and 17 #3269

Closed
hoangduy0610 opened this issue Dec 22, 2023 · 6 comments
Closed

Cannot use menuItems on iOS 16 and 17 #3269

hoangduy0610 opened this issue Dec 22, 2023 · 6 comments
Labels
Stale Type: bug report

Comments

@hoangduy0610
Copy link

Bug description:
menuItems props not working properly on iOS 16 and iOS 17 due to deprecated UIMenuController. Apple suggest using UIEditMenuInteraction instead.

To Reproduce:
Implement menuItems and observe

Expected behavior:
The context menu should be shown

Environment:

  • OS: iOS
  • OS version: >= 16
@hoangduy0610
Copy link
Author

I fixed this by myself
PR: #3272

@hoangduy0610
Copy link
Author

@Titozzz @jamonholmgren Please review my PR and link to this issue

@hoangduy0610 hoangduy0610 mentioned this issue Dec 25, 2023
Closed
hoangduy0610 added a commit to hoangduy0610/react-native-webview that referenced this issue Dec 25, 2023
@hoangduy0610
Update RNCWebViewImpl.m react-native-webview#3269
6a82b36 
react-native-webview#3269
@hoangduy0610
Copy link
Author

@Titozzz @jamonholmgren Please take a look of this PR

@hoangduy0610
Copy link
Author

@chiaramooney please take a look to my PR : #3272

@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Apr 17, 2024
@hoangduy0610
Copy link
Author

Still waiting for PR to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale Type: bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hoangduy0610