Added support of pull down to refresh feature for Android platform. #2787

muskan273 · 2022-12-26T13:13:09Z

No description provided.

Kasea

First, I love how "fast" react-native libraries/developers are when it comes to "bugs" that have existed in their libraries for years that are a huge deal breaker 😄.

Getting to the PR though; There are a couple of problems which are a "deal breaker" (imo).

When dealing with a public project or any project for that matter, ALWAYS conform to the code bases code style/practices.
This includes how they leave comments, indentation, ordering of methods (although it might be random, see next point), method/property naming and everything else inbetween.
You've mostly done this, although there are places where you've changed indentation (to the correct one technically, but see next point) and added spaces.

When dealing with a public project, always keep the PRs as small as possible. I can see you've "fixed" a lot of formatting "errors", but this just adds to more code to review. Keep it as simple as possible. If this was at a company I would be happy to see some code cleanup, but these developers are not paid and want to do the least possible 😓 . You've also moved around a couple of methods and in some cases duplicated them. Don't do unnecessary work!

android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java

Kasea · 2023-01-31T09:09:56Z

NOTE: if you have a modal with overflow, scroll down on said modal, release and then try to scroll up, it'll refresh instead of scrolling up.

This is working as intended on iOS

snaptravel-eng · 2023-02-28T08:05:15Z

Hi @Kasea @muskan273, what do we need to do to get this merged in? Is the only issue the code style/formatting or is the modal with overflow a dealbreaker?

stanimirsellercloud · 2023-02-28T09:42:25Z

@snaptravel-eng I think this also fixes pull to refresh on Android. It seems to be working on iOS only.

snaptravel-eng · 2023-03-01T06:08:19Z

Thanks. Yeah I understand the intention. How do we get this merged instead of stuck as a PR?

stanimirsellercloud · 2023-03-01T06:32:18Z

cc @Titozzz @Saadnajmi

rafaelmonroy · 2023-03-16T17:24:05Z

does anyone know when this is getting merged? 👀 @muskan273 @Kasea @Titozzz @Saadnajmi

muskan273 · 2023-03-18T19:01:00Z

@Kasea @jamonholmgren @Titozzz Can you please review the latest commit? I have made changes as suggested above. Let me know if I need to make any changes.

snaptravel-eng · 2023-04-06T03:40:45Z

Thanks for updating @muskan273 !

How do we get this merged instead of stuck as a PR? @Kasea @jamonholmgren @Titozzz

muskan273 · 2023-04-11T16:13:15Z

NOTE: if you have a modal with overflow, scroll down on said modal, release and then try to scroll up, it'll refresh instead of scrolling up.

This is working as intended on iOS

muskan273 · 2023-04-11T16:26:17Z

NOTE: if you have a modal with overflow, scroll down on said modal, release and then try to scroll up, it'll refresh instead of scrolling up.

This is working as intended on iOS

I faced the same issue while implementing that feature. I have mentioned the solution in the below blog:
https://dev.to/muskanparashar/react-native-webview-make-android-pulltorefresh-work-without-any-glitches-467

peterlazar1993 · 2023-04-19T08:18:13Z

@muskan273 Congrats on your first PR!
I'd love to test this, could you please rebase master.

Muneeb926595 · 2023-04-20T05:10:45Z

is there anyone who can rebase master please i need this PR urgently.

snaptravel-eng · 2023-05-03T04:34:48Z

Is there any blocker for updating and merging this? The open bounty still applies: #2678
Thanks

StephenCavender · 2023-05-03T14:22:13Z

this pr doesn't work for loading web pages that have nested scroll views. The page i'm trying to load has a scrollable content block between a sticky header and footer. I can't scroll up within the scrollable content, it just triggers the refresh.

Repro is to replace the example for Scrolling with this:

import React, { Component } from 'react';
import { Button, Text, View } from 'react-native';

import WebView from 'react-native-webview';

const HTML = `
<!DOCTYPE html>\n
<html>
  <head>
    <title>Hello World</title>
    <meta http-equiv="content-type" content="text/html; charset=utf-8">
    <meta name="viewport" content="width=320, user-scalable=no">
    <style type="text/css">
    #flexbox_container {
      display: flex;
      flex-direction: column;
      box-shadow: 0 4px 5px -2px #999;
      height: 90%;
    }
    
    .flex_item {
      background: #eee;
      margin: 4px;
      padding: 10px;
    }
    
    .middle {
      flex-grow: 1;
      overflow: auto;
    }
    
    html,
    body {
      height: 100%;
    }
    </style>
  </head>
  <body>
  <div id="flexbox_container">
  <div class="flex_item">
    Item</div>
  <div class="flex_item middle">
    <p>1</p>
    <p>2</p>
    <p>3</p>
    <p>4</p>
    <p>5</p>
    <p>6</p>
    <p>7</p>
    <p>8</p>
    <p>9</p>
    <p>10</p>
    <p>11</p>
    <p>12</p>
    <p>13</p>
  </div>
  <div class="flex_item">Item</div>
</div>
  </body>
</html>
`;

type Props = {};
type State = {
  scrollEnabled: boolean;
  lastScrollEvent: string;
};

export default class Scrolling extends Component<Props, State> {
  state = {
    scrollEnabled: true,
    lastScrollEvent: '',
  };

  render() {
    return (
      <View>
        <View style={{ height: 240 }}>
          <WebView
            source={{ html: HTML }}
            automaticallyAdjustContentInsets={false}
            onScroll={this._onScroll}
            scrollEnabled={this.state.scrollEnabled}
          />
        </View>
        <Button
          title={
            this.state.scrollEnabled ? 'Scroll enabled' : 'Scroll disabled'
          }
          onPress={() =>
            this.setState({ scrollEnabled: !this.state.scrollEnabled })
          }
        />
        <Text>Last scroll event:</Text>
        <Text>{this.state.lastScrollEvent}</Text>
      </View>
    );
  }

  _onScroll = (event) => {
    this.setState({ lastScrollEvent: JSON.stringify(event.nativeEvent) });
  };
}

Recording of behavior:
https://user-images.githubusercontent.com/6619472/235944464-2d826e6e-4ef2-40ff-853b-a682b6f54169.mov

github-actions · 2023-07-03T00:17:46Z

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

muskan273 · 2023-08-22T06:53:32Z

Hi, I wanted to bring your attention back to a closed pull request that I believe requires further consideration. I have identified a solution for the issue discussed in this comment: #2787 (comment).
You can review the proposed solution in the attached file provided below:

WebviewRefresh.js.zip

Looking forward to your feedback and the possibility of reopening and resolving this pull request.
@Kasea @StephenCavender @snaptravel-eng @stanimirsellercloud @rafaelmonroy @peterlazar1993

muskan273 added 5 commits March 28, 2022 14:26

Pull to refresh feature added

ad0a249

Fixed issues related to the webview callbacks

18289c3

pull to refresh related fixes

ea346b0

Removed logs and done pull to refresh fixes

706eff4

Added pull to refresh feature for android platform

66b48d8

muskan273 requested review from Titozzz and jamonholmgren as code owners December 26, 2022 13:13

muskan273 closed this Dec 26, 2022

muskan273 reopened this Dec 26, 2022

Merge branch 'master' into feature/pull_to_refresh_android

ab62083

This was referenced Dec 27, 2022

$500 Bounty - Official SwipeRefreshLayout for Android (PTR for iOS already solved) #2678

Closed

Pull to refresh is not working on android with react native webview #2468

Closed

Kasea suggested changes Jan 27, 2023

View reviewed changes

Removed duplicate code & logs

71bd8a1

Merge branch 'master' into feature/pull_to_refresh_android

f02fd2b

muskan273 closed this Apr 11, 2023

muskan273 reopened this Apr 11, 2023

github-actions bot added the Stale label Jul 3, 2023

github-actions bot closed this Jul 10, 2023

muskan273 mentioned this pull request Sep 5, 2023

Added support of pull down to refresh feature for Android platform. #3130

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support of pull down to refresh feature for Android platform. #2787

Added support of pull down to refresh feature for Android platform. #2787

muskan273 commented Dec 26, 2022

Kasea left a comment

Kasea commented Jan 31, 2023 •

edited

snaptravel-eng commented Feb 28, 2023 •

edited

stanimirsellercloud commented Feb 28, 2023 •

edited

snaptravel-eng commented Mar 1, 2023

stanimirsellercloud commented Mar 1, 2023

rafaelmonroy commented Mar 16, 2023

muskan273 commented Mar 18, 2023 •

edited

snaptravel-eng commented Apr 6, 2023

muskan273 commented Apr 11, 2023

muskan273 commented Apr 11, 2023 •

edited

peterlazar1993 commented Apr 19, 2023

Muneeb926595 commented Apr 20, 2023 •

edited

snaptravel-eng commented May 3, 2023

StephenCavender commented May 3, 2023

github-actions bot commented Jul 3, 2023

muskan273 commented Aug 22, 2023 •

edited

Added support of pull down to refresh feature for Android platform. #2787

Added support of pull down to refresh feature for Android platform. #2787

Conversation

muskan273 commented Dec 26, 2022

Kasea left a comment

Choose a reason for hiding this comment

Kasea commented Jan 31, 2023 • edited

snaptravel-eng commented Feb 28, 2023 • edited

stanimirsellercloud commented Feb 28, 2023 • edited

snaptravel-eng commented Mar 1, 2023

stanimirsellercloud commented Mar 1, 2023

rafaelmonroy commented Mar 16, 2023

muskan273 commented Mar 18, 2023 • edited

snaptravel-eng commented Apr 6, 2023

muskan273 commented Apr 11, 2023

muskan273 commented Apr 11, 2023 • edited

peterlazar1993 commented Apr 19, 2023

Muneeb926595 commented Apr 20, 2023 • edited

snaptravel-eng commented May 3, 2023

StephenCavender commented May 3, 2023

github-actions bot commented Jul 3, 2023

muskan273 commented Aug 22, 2023 • edited

Kasea commented Jan 31, 2023 •

edited

snaptravel-eng commented Feb 28, 2023 •

edited

stanimirsellercloud commented Feb 28, 2023 •

edited

muskan273 commented Mar 18, 2023 •

edited

muskan273 commented Apr 11, 2023 •

edited

Muneeb926595 commented Apr 20, 2023 •

edited

muskan273 commented Aug 22, 2023 •

edited