[#3289] Android: Trigger onError
callback on asset loading errors
#3290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR for #3289:
onReceivedError
foronError
implementation on Android.onError
callback, if provided, for asset loading errors, in addition to the primary source loading errors.onLoad
,onLoadEnd
, etc.); i.e.onError
signals triggered for page assets do not preventonLoad
andonLoadEnd
to be fired for the page itself, if that was loaded — thus, the page is signaled to have been loaded successfully, even if its assets failed to load, and that is just the original behavior of those signals before my PR.Can we merge it, please? :)