feat(WKWebView): Allow focus without user interaction #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ericlewis , thanks for this PR!
Otherwise, I'm fine with this new property. |
|
iOS Simulator 11.4 seems to work |
|
iOS Simulator 12.2 works |
|
iOS Simulator 9.3 works |
Titozzz
approved these changes
Apr 29, 2019
Titozzz
changed the title
|
@allcontributors[bot] please add @ericlewis for code,doc |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@allcontributors[bot] please add @ericlewis for code doc |
|
I've put up a pull request to add @ericlewis! 🎉 |
react-native-community-bot
pushed a commit
that referenced
this pull request
Apr 29, 2019
# [5.8.0](v5.7.2...v5.8.0) (2019-04-29) ### Features * **WKWebView:** Allow focus without user interaction ([#540](#540)) ([455c30e](455c30e))
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Same |
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
…ebview#540) * [iOS] Allow focus without user interaction * Add documentation for keyboardDisplayRequiresUserAction * set keyboardDisplayRequiresUserAction default to true
phuongwd
pushed a commit
to phuongwd/react-native-webview
that referenced
this pull request
Apr 29, 2020
# [5.8.0](react-native-webview/react-native-webview@v5.7.2...v5.8.0) (2019-04-29) ### Features * **WKWebView:** Allow focus without user interaction ([react-native-webview#540](react-native-webview#540)) ([455c30e](react-native-webview@455c30e))
noproblem23
added a commit
to noproblem23/react-native-webview
that referenced
this pull request
Apr 18, 2023
# [5.8.0](react-native-webview/react-native-webview@v5.7.2...v5.8.0) (2019-04-29) ### Features * **WKWebView:** Allow focus without user interaction ([#540](react-native-webview/react-native-webview#540)) ([455c30e](react-native-webview/react-native-webview@455c30e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt at solving #278 for iOS. It introduces a new prop called
keyboardDisplayRequiresUserAction. Setting it tofalsewill allow the WebView to bring up the keyboard on focus events. It works on 9.0-12.2. It works by swizzling WKContentView, with different versions for the 11.3-12.20+ ranges.Testing strategy
Created a new app using react-native init using my modified version, setting
https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_text_autofocusas the source. When set to false, it would autofocus, when set to true it didn't. I also tried combining it withhideKeyboardAccessoryViewwhich also swizzles, and all combinations worked fine.Please let me know what else needs to be done, such as updating docs? Should I also update the UIWebView version? I don't have a lot of expertise in Android, but am happy to tackle that maybe next.