Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports broken on case sensitive file system #50

Closed
thdk opened this issue Jan 26, 2021 · 4 comments · Fixed by #51
Closed

Imports broken on case sensitive file system #50

thdk opened this issue Jan 26, 2021 · 4 comments · Fixed by #51

Comments

@thdk
Copy link
Contributor

thdk commented Jan 26, 2021

As mentioned already in #9 some imports are using wrong casing when importing modules.

Filenames for Driver, Config and WinAppDriver are in PascalCasing while pageobject and by2 are in lowercase.
@licanhua
Copy link
Collaborator

Is it possible for you to create a pull request? I'm using windows and it's not case sensitive

@thdk
Copy link
Contributor Author

thdk commented Jan 26, 2021

@licanhua of course I'm on it.
Would you be interested in a PR to add eslint to avoid these errors in the future?

@thdk thdk mentioned this issue Jan 26, 2021
Merged
@licanhua
Copy link
Collaborator

sure

@thdk thdk mentioned this issue Jan 26, 2021
Merged
@licanhua
Copy link
Collaborator

Thanks. I just published 1.0.1 package. and please let me know if there is any problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix casing in imports thdk/selenium-appium
2 participants
@thdk @licanhua