Add eslint #52
Merged
Add eslint #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
licanhua
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues such as #9 #50 regarding file imports on case sensitive file systems (often used in CI/CD) I would recommend running eslint as part of the build process.
I didn't 'hook' it in yet, so for now it should still be run manually with
npm run lintbefore publishing new version.I've disabled some recommended rules so this PR can stay minimal. Once this is merge, and if required, I can fix those lint rules as well.
I've noted that eslint keeps complaing when importing from selenium webdriver which seems to be cause by an invalid value in the
mainfield of theirpackage.jsonfile. I'll let them now.