fix: proper prop naming on module declaration

react-navigation · Aug 3, 2019 · be788e9 · be788e9
1 parent 9434c59
commit be788e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/index.tsx b/src/index.tsx
@@ -29,13 +29,13 @@ const DEFAULT_TRANSITION = (
 
 interface Props {
   navigation: NavigationProp<NavigationState> & {
-    navigationConfig: { transition?: React.ElementType<Transition> };
+    navigationConfig: { transition?: React.ReactNode };
   };
   descriptors: { [key: string]: NavigationDescriptor };
   screenProps?: ScreenProps;
 }
 
-class AnimatedSwitchView extends React.Component<Props> {
+class AnimatedSwitchView extends React.Component<Props, {}> {
   containerRef = React.createRef<TransitioningView>();
 
   componentDidUpdate(prevProps: Props) {
@@ -75,13 +75,13 @@ class AnimatedSwitchView extends React.Component<Props> {
 }
 
 export interface AnimatedSwitchNavigatorConfig extends SwitchNavigatorConfig {
-  transition?: React.ElementType<Transition>;
+  transition?: React.ReactNode;
 }
 
 export default function createAnimatedSwitchNavigator(
   routeConfigMap: NavigationRouteConfigMap,
   switchConfig: SwitchNavigatorConfig & {
-    transition?: React.ElementType<Transition>;
+    transition?: React.ReactNode;
   }
 ): NavigationContainer {
   const router = SwitchRouter(routeConfigMap, switchConfig);

diff --git a/types/@react-navigation/core.d.ts b/types/@react-navigation/core.d.ts
@@ -5,6 +5,7 @@ declare module '@react-navigation/core' {
     NavigationRouteConfigMap,
     NavigationContainer,
     SwitchNavigatorConfig,
+    NavigationRouter,
   } from 'react-navigation';
 
   export const SceneView: React.ComponentType<{
@@ -15,14 +16,14 @@ declare module '@react-navigation/core' {
 
   export function createNavigator(
     StackView: React.ComponentType<any>,
-    router: any,
-    stackConfig: object
+    router: NavigationRouter<S, Options>,
+    navigatorConfig?: {} | null
   ): NavigationContainer;
 
   export function SwitchRouter(
     routeConfigMap: NavigationRouteConfigMap,
     switchConfig: SwitchNavigatorConfig & {
-      transition?: React.ElementType<Transition>;
+      transition?: React.ReactNode;
     }
   );
 }