feat: add drawer navigator integration #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 93.81% 93.83% +0.01%
==========================================
Files 21 21
Lines 372 373 +1
Branches 93 93
==========================================
+ Hits 349 350 +1
Misses 22 22
Partials 1 1
Continue to review full report at Codecov.
|
|
same #42 (review) |
satya164
force-pushed
the
@satya164/drawer
branch
from
11d7ab9
to
694453e
Compare
| @@ -0,0 +1,117 @@ | |||
| import { StyleProp, ViewStyle, TextStyle } from 'react-native'; | |||
There was a problem hiding this comment.
everything for this point is copied right?
There was a problem hiding this comment.
yeah, the only thing I have changed are types + replaced onDrawerX callbacks with events.
There was a problem hiding this comment.
oh, I also added DrawerRouter (second file from last)
| "@types/react-native": "^0.60.2", | ||
| "react": "16.8.3", | ||
| "react-native": "^0.59.8", | ||
| "react-native-gesture-handler": "^1.3.0", |
There was a problem hiding this comment.
basically so that tools like typescript and eslint will resolve it. similar to how we have it in tab view. in this monorepo, it'll be hoisted to top
packages/core/src/types.tsx
Outdated
| @@ -378,7 +395,7 @@ export type RouteConfig< | |||
| | ScreenOptions | |||
| | ((props: { | |||
| route: RouteProp<ParamList, RouteName>; | |||
| navigation: NavigationHelpersCommon<ParamList>; | |||
| navigation: any; | |||
There was a problem hiding this comment.
screens receive a more complex navigation type (as in the README), and it's not really possible to type it properly here. that's why it's any. users need to type it manually like in README.
satya164
force-pushed
the
@satya164/drawer
branch
from
694453e
to
2da65c2
Compare
No description provided.