fix(core): removal of non-existing listener should not break updating navigation container ref #10067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey split! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
|
✔️ Deploy Preview for react-navigation-example ready! 🔨 Explore the source changes: 464d058 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/6170319a026d9a0007d567a7 😎 Browse the preview: https://deploy-preview-10067--react-navigation-example.netlify.app/ |
MohamedLamineAllal
pushed a commit
to MohamedLamineAllal/react-navigation
that referenced
this pull request
Feb 4, 2022
…eact-navigation#10067) Calling `removeListener` on event that doesn't have any listeners will add new key for that event to listeners with value `undefined`. After that attempts to set `ref.current` will fail with "Cannot read property 'forEach' of undefined" error. Fix is quite simple. Just needed to add check if there is listeners for the given event. FYI @satya164. This is related to your recent change react-navigation@acdde18
MohamedLamineAllal
pushed a commit
to MohamedLamineAllal/react-navigation
that referenced
this pull request
Feb 4, 2022
…eact-navigation#10067) Calling `removeListener` on event that doesn't have any listeners will add new key for that event to listeners with value `undefined`. After that attempts to set `ref.current` will fail with "Cannot read property 'forEach' of undefined" error. Fix is quite simple. Just needed to add check if there is listeners for the given event. FYI @satya164. This is related to your recent change react-navigation@acdde18
MohamedLamineAllal
pushed a commit
to MohamedLamineAllal/react-navigation
that referenced
this pull request
Feb 4, 2022
…eact-navigation#10067) Calling `removeListener` on event that doesn't have any listeners will add new key for that event to listeners with value `undefined`. After that attempts to set `ref.current` will fail with "Cannot read property 'forEach' of undefined" error. Fix is quite simple. Just needed to add check if there is listeners for the given event. FYI @satya164. This is related to your recent change react-navigation@acdde18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
removeListeneron event that doesn't have any listeners will add new key for that event to listeners with valueundefined. After that attempts to setref.currentwill fail with "Cannot read property 'forEach' of undefined" error. Fix is quite simple. Just needed to add check if there is listeners for the given event.FYI @satya164. This is related to your recent change acdde18