Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LinkingContext #10604

Merged
merged 2 commits into from Jul 5, 2022
Merged

Conversation

nandorojo
Copy link
Contributor

Without this, it is impossible to build your own hooks using getPathFromState and getStateFromAction.

This addresses #10517

Motivation

This lets solito implement a replace('/users/fernando') logic using URLs.

Test plan

It's only exporting a variable.

Without this, it is impossible to build your own hooks using `getPathFromState` and `getStateFromAction`.

This addresses react-navigation#10517
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit fed5c3c
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/62bf3b8b5c0e210009d0f30e
😎 Deploy Preview https://deploy-preview-10604--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hey nandorojo! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164
Copy link
Member

CI is failing in your PR because of lint. Can you fix it?

@nandorojo
Copy link
Contributor Author

yup I’ll fix it, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #10604 (fed5c3c) into main (5b13f81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10604   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files         160      160           
  Lines        4991     4991           
  Branches     1947     1947           
=======================================
  Hits         3687     3687           
  Misses       1267     1267           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b13f81...fed5c3c. Read the comment docs.

@nandorojo
Copy link
Contributor Author

Fixed, tests are passing now.

@kacperkapusciak kacperkapusciak merged commit ac24e61 into react-navigation:main Jul 5, 2022
@Titozzz
Copy link
Contributor

Titozzz commented Jul 8, 2022

Yay, I've been importing from import LinkingContext from '@react-navigation/native/src/LinkingContext'; for so long

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants