chore: upgrade expo sdk, react-native & other dependencies #10655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The Expo app for the example from this branch is ready! expo.dev/@react-navigation/react-navigation-example?release-channel=pr-10655 |
satya164
approved these changes
Jun 27, 2022
kacperkapusciak
added a commit
that referenced
this pull request
Jun 28, 2022
After the upgrade of dependencies in #10655 CI is failing while building packages. The problem seems to lay in the inconsistency of taking types from the @types/react package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to properly test new native-stack props that will be added in #10578 react-navigation repo has to be upgraded to use Expo SDK 45 which comes with react-native-screens v3.11.1.
Actions taken
@types/react-nativeupgradeios/andandroid/directories in example/ withexpo prebuildcommandLint, typescript check & e2e tests pass ✅