fix: PanGestureHandlerGestureEvent is a type and should be exported as such
#10814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey renchap! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #10814 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 167 167
Lines 5130 5130
Branches 1986 1986
=======================================
Hits 3843 3843
Misses 1248 1248
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PanGestureHandlerGestureEventis exported as a value, but is a type. This makes it included in the transpiled published code, which is incorrect and makesesbuilderror it tries to consume the code (for example with https://microsoft.github.io/rnx-kit/docs/tools/metro-serializer-esbuild).Test plan
There should not be any special test plans here, and the issue only happens when a non-standard RN/Metro setup is used. I tried the fix on my app using the ESBuild serializer mentioned above and it fixed the issue.