fix: add additional check before running animate in componentDidUpdate
#10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to support the new Fabric renderer
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The Expo app for the example from this branch is ready! expo.dev/@react-navigation/react-navigation-example?release-channel=pr-10871 |
Codecov ReportBase: 75.47% // Head: 75.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10871 +/- ##
==========================================
- Coverage 75.47% 75.43% -0.04%
==========================================
Files 167 167
Lines 5129 5130 +1
Branches 1985 1986 +1
==========================================
- Hits 3871 3870 -1
- Misses 1220 1222 +2
Partials 38 38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
satya164
approved these changes
Sep 25, 2022
kacperkapusciak
deleted the
@kacperkapusciak/fix-migrate-off-setNativeProps
branch
kacperkapusciak
added a commit
that referenced
this pull request
Nov 4, 2022
### Motivation This PR is a third attempt to migrate setNativeProps to state in @react-navigation/stack following the official Moving setNativeProps to state guide. After issues with the implementation of #10767 and more problems with the fix in #10871 we had to take a step back and rethink where the problem lays with these implementations. The solution was to move the state inside the CardSheet component and use useImperativeHandle to hoist a setter function up to Card to avoid triggering a rerender during Card animate function.
kacperkapusciak
added a commit
that referenced
this pull request
Nov 4, 2022
### Motivation This PR is a third attempt to migrate setNativeProps to state in @react-navigation/stack following the official Moving setNativeProps to state guide. After issues with the implementation of #10767 and more problems with the fix in #10871 we had to take a step back and rethink where the problem lays with these implementations. The solution was to move the state inside the CardSheet component and use useImperativeHandle to hoist a setter function up to Card to avoid triggering a rerender during Card animate function.
kacperkapusciak
added a commit
to josemak25/react-navigation
that referenced
this pull request
Dec 15, 2022
…entDidUpdate` (react-navigation#10871)" This reverts commit b9fb2d1.
kacperkapusciak
added a commit
to josemak25/react-navigation
that referenced
this pull request
Dec 15, 2022
### Motivation This PR is a third attempt to migrate setNativeProps to state in @react-navigation/stack following the official Moving setNativeProps to state guide. After issues with the implementation of react-navigation#10767 and more problems with the fix in react-navigation#10871 we had to take a step back and rethink where the problem lays with these implementations. The solution was to move the state inside the CardSheet component and use useImperativeHandle to hoist a setter function up to Card to avoid triggering a rerender during Card animate function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changed introduced in #10767 created a regression reported in #10856 which made it impossible to close a modal with a gesture.
As we want to change pointer-events on Card in
componentDidUpdateprevious use ofsetNativePropsin this context made a lot of sense. SincesetNativePropsis going to be removed in the new architecture we had to migrate it to the component state as stated in the migration guide.This PR adds an additional
closing !== prevProps.closingcheck on top of #10767 withincomponentDidUpdateinCard.tsx.Test plan
ModalStack example
Recordings
Before
Screen.Recording.2022-09-21.at.12.35.45.mov
After
Screen.Recording.2022-09-21.at.12.34.51.mov
Issue the aforementioned PR fixed originally still works
Screen.Recording.2022-09-21.at.12.33.11.mov