fix: keep hash/fragment section for initial render #11078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
satya164
requested changes
Dec 6, 2022
There was a problem hiding this comment.
Thanks for the PR. I think we should also preserve the hash on URL updates (if the screen didn't change). For now, we could only check if the path didn't change and preserve the hash.
Can you move this logic to history.replace function where it preserves the hash if path is the same?
|
@satya164 force pushed a fix that works no as you described and in History.replace |
satya164
pushed a commit
that referenced
this pull request
Dec 11, 2022
**Motivation** Fixes this issue that I discovered #11026 **Test plan** 1. Run the example 2. Visit http://localhost:19006/simple-stack/article/gandalf#test 3. The with #test part still exists 4. Note that if you change the hash it will be gone (this is expected)
satya164
pushed a commit
that referenced
this pull request
Feb 17, 2023
**Motivation** Fixes this issue that I discovered #11026 **Test plan** 1. Run the example 2. Visit http://localhost:19006/simple-stack/article/gandalf#test 3. The with #test part still exists 4. Note that if you change the hash it will be gone (this is expected)
satya164
pushed a commit
that referenced
this pull request
Feb 17, 2023
**Motivation** Fixes this issue that I discovered #11026 **Test plan** 1. Run the example 2. Visit http://localhost:19006/simple-stack/article/gandalf#test 3. The with #test part still exists 4. Note that if you change the hash it will be gone (this is expected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes this issue that I discovered #11026
Test plan