feat: add shifting animation to bottom-tabs and various fixes #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11581 +/- ##
==========================================
+ Coverage 75.72% 75.74% +0.02%
==========================================
Files 198 198
Lines 5795 5809 +14
Branches 2268 2269 +1
==========================================
+ Hits 4388 4400 +12
- Misses 1360 1362 +2
Partials 47 47
☔ View full report in Codecov by Sentry. |
|
The Expo app for the example from this branch is ready! |
This adds a new shifting animation preset to bottom tabs, as well as various animation related fixes. - Instead of `0`, `1` for animated value, use `-1`, `0`, `1` - so that it can represent both focus state and direction - Animate with `duration: 0` when animation is not enabled - this ensures that the animation values stay in sync - Add correct types to animated styles instead of `any`
satya164
force-pushed
the
@satya164/bottom-tab-animation
branch
from
c35b4b9
to
b334c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new shifting animation preset to bottom tabs, as well as various animation related fixes.
0,1for animated value, use-1,0,1- so that it can represent both focus state and directionduration: 0when animation is not enabled - this ensures that the animation values stay in syncanyKapture.2023-09-05.at.11.40.24.mp4