New API for unhandled linking #11672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Previously when using nested navigation API, we used that screen as `initialRouteName`.
e.g.
```js
navigation.navigate('MyScreen', { screen: 'NestedScreen' });
```
Here, the `'NestedScreen`` will be set as `initialRouteName`.
It has the result of rendering the navigator with that screen as focused screen. While this behaviour is expected, that screen was also used as the `initialRouteName` for every other operation ignoring the `initialRouteName` prop - which is not expected.
This change refactors the way the focused screen for initial render is set to avoid this behavior.
|
The Expo app for the example from this branch is ready! |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11672 +/- ##
==========================================
+ Coverage 75.76% 75.98% +0.21%
==========================================
Files 208 207 -1
Lines 5976 5937 -39
Branches 2321 2299 -22
==========================================
- Hits 4528 4511 -17
+ Misses 1398 1376 -22
Partials 50 50
☔ View full report in Codecov by Sentry. |
This reverts commit 8bf8551.
satya164
requested changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the API easier, we decided to make the hook attached directly to the navigator, instead of returning the function to handle the link.
Now, an unhandled link will be handled on the route change via the provided callback. In order to cancel unhandled links, we provide an additional function
clearUnhandledLink