feat: rewrite drawer for a new RNGH API #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdnk
commented
Jan 9, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11776 +/- ##
==========================================
+ Coverage 77.23% 77.25% +0.01%
==========================================
Files 211 209 -2
Lines 6317 6313 -4
Branches 2495 2496 +1
==========================================
- Hits 4879 4877 -2
+ Misses 1384 1382 -2
Partials 54 54 ☔ View full report in Codecov by Sentry. |
|
The Expo app for the example from this branch is ready! |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
satya164
requested changes
Jan 10, 2024
packages/react-native-drawer-layout/src/views/GestureHandler.tsx
Outdated
Show resolved
Hide resolved
satya164
reviewed
Jan 11, 2024
packages/react-native-drawer-layout/src/views/GestureHandler.tsx
Outdated
Show resolved
Hide resolved
osdnk
commented
Jan 11, 2024
satya164
force-pushed
the
@osdnk/rngh-drawer
branch
from
f7faa22
to
1cb70e0
Compare
|
The Expo app for the example from this branch is ready! |
…t-navigation into @osdnk/rngh-drawer
satya164
reviewed
Feb 23, 2024
|
I found an issue. When the drawer is on the right and I close it via gesture, it doesn't close fullly. Kapture.2024-03-17.at.14.35.28.mp4 |
|
@satya164 I addressed the problem |
satya164
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the drawer to the new API.
Screen.Recording.2024-02-11.at.20.45.55.mov