Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type errors when getState used outside of a screen #11827

Merged
merged 4 commits into from Feb 23, 2024

Conversation

MrRefactor
Copy link
Contributor

This PR addresses the issue: 11701

Copy link

Hey @MrRefactor! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 76.59%. Comparing base (df2f397) to head (b261519).

❗ Current head b261519 differs from pull request most recent head e5d4d9e. Consider uploading reports for the commit e5d4d9e to get more accurate results

Files Patch % Lines
packages/core/src/BaseNavigationContainer.tsx 0.00% 4 Missing ⚠️
packages/native/src/useScrollToTop.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11827      +/-   ##
==========================================
- Coverage   76.66%   76.59%   -0.08%     
==========================================
  Files         208      208              
  Lines        6129     6135       +6     
  Branches     2402     2403       +1     
==========================================
  Hits         4699     4699              
- Misses       1377     1383       +6     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit e5d4d9e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/65d8f336e867660008eea5f8
😎 Deploy Preview https://deploy-preview-11827--react-navigation-example.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@osdnk osdnk enabled auto-merge (squash) February 23, 2024 19:34
@osdnk osdnk disabled auto-merge February 23, 2024 19:34
@osdnk osdnk enabled auto-merge (squash) February 23, 2024 19:35
@osdnk osdnk disabled auto-merge February 23, 2024 19:35
@osdnk osdnk merged commit b3512a5 into react-navigation:main Feb 23, 2024
8 checks passed
satya164 pushed a commit that referenced this pull request Feb 24, 2024
Closes #11701

---------

Co-authored-by: Michał Osadnik <micosa97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants