Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve # in the URL if the screen hasn't changed - partially done #11876

Merged
merged 6 commits into from Mar 8, 2024

Conversation

groot007
Copy link
Member

@groot007 groot007 commented Mar 7, 2024

Motivation

when updating some params on the page, the hash shouldn’t be removed

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 302058f
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/65eb3d6d9f10960008553243
😎 Deploy Preview https://deploy-preview-11876--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/native/src/useLinking.tsx Outdated Show resolved Hide resolved
@satya164
Copy link
Member

satya164 commented Mar 7, 2024

Also let's add some tests as well. You can add them under example/e2e.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.13%. Comparing base (b146aed) to head (84bc657).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11876      +/-   ##
==========================================
+ Coverage   76.99%   77.13%   +0.13%     
==========================================
  Files         207      209       +2     
  Lines        6151     6193      +42     
  Branches     2420     2442      +22     
==========================================
+ Hits         4736     4777      +41     
- Misses       1361     1362       +1     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satya164 satya164 enabled auto-merge (squash) March 8, 2024 16:32
@satya164 satya164 merged commit 66cc899 into react-navigation:main Mar 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants