Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.0-alpha static router conditional not working on iOS #11884

Open
2 of 11 tasks
b0iq opened this issue Mar 11, 2024 · 7 comments
Open
2 of 11 tasks

7.0.0-alpha static router conditional not working on iOS #11884

b0iq opened this issue Mar 11, 2024 · 7 comments

Comments

@b0iq
Copy link

b0iq commented Mar 11, 2024

Current behavior

When the context updated it showing blank screen on iOS only

Expected behavior

it should navigate or replace the current screen

Reproduction

https://snack.expo.dev/kzNqGjJ0vCaf3-tcFgHrm

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

  • @react-navigation/bottom-tabs
  • @react-navigation/drawer
  • @react-navigation/material-top-tabs
  • @react-navigation/stack
  • @react-navigation/native-stack
  • react-native-tab-view

Environment

    "@react-navigation/native": "7.0.0-alpha.12",
    "@react-navigation/native-stack": "7.0.0-alpha.13",
    "react-native-safe-area-context": "^4.9.0",
    "react-native-screens": "^3.29.0",
Copy link

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • @react-navigation/native (found: 7.0.0-alpha.12, latest: 6.1.15)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@satya164
Copy link
Member

satya164 commented Mar 11, 2024

You need to provide a runnable repro. I tried the example from the docs on my iPhone and it works as expected https://reactnavigation.org/docs/7.x/auth-flow#implement-the-logic-for-restoring-the-token

Copy link

Hey @b0iq! Thanks for opening the issue. It seems that the issue doesn't contain a link to a repro.

The best way to get attention to your issue is to provide an easy way for a developer to reproduce the issue.

You can provide a repro using any of the following:

A snack link is preferred since it's the easiest way to both create and share a repro. If it's not possible to create a repro using a snack, link to a GitHub repo under your username is a good alternative. Don't link to a branch or specific file etc. as it won't be detected.

Try to keep the repro as small as possible by narrowing down the minimal amount of code needed to reproduce the issue. Don't link to your entire project or a project containing code unrelated to the issue. See "How to create a Minimal, Reproducible Example" for more information.

You can edit your original issue to include a link to the repro, or leave it as a comment. The issue will be closed automatically after a while if you don't provide a repro.

@b0iq
Copy link
Author

b0iq commented Mar 11, 2024

Dear @satya164, I tried the repro. same issue.
I found that the issue maybe because of I have enable fabric and new architecture.

So the question is... is it going to be supported soon?

@satya164
Copy link
Member

Can you open an issue in React Native Screens repo for Fabric?

Copy link

Hey! Thanks for opening the issue. Seems that this issue is related to react-native-screens library which is a dependency of React Navigation. Can you also post your issue in this repo so that it's notified to the maintainers of that library? This will help us fix the issue faster since it's upto the maintainers of that library to investigate it.

@tboba
Copy link
Contributor

tboba commented May 6, 2024

Hi @b0iq! I just tested this bug on react-native-screens with version 3.31.1 and I can see this isn't reproducible anymore (I also tested 3.29.0 and the issue was there indeed). Could you check if bumping the version fixes this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants