-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SafeAreaView working not well in TabNavigator #3767
Comments
cc @davepack |
Hey! Can you update your snack to demonstrate the issue you're having? The snack doesn't match your screenshot. |
We see this same behavior. I don't have a Snack available right now, but I can add:
|
I am seeing the same issue. Are there any updates on this? |
I tried to create a Snack but that seems compatible with neither react-navigation nor iPhoneX. But repro is very simple: Run (the issue affects all three tabs, although it can be slightly harder to see on the Home tab simply due to the centered content) |
Sorry for my delay in getting to this. Your analysis is right on, the react-navigation tab view is one of the particular cases that pushed me to create the js version of SafeAreaView. I think ideally the |
So to sum up, the solution to this issue is to use the js version of SafeAreaView. import { SafeAreaView } from 'react-navigation';
// or
import SafeAreaView from 'react-native-safe-area-view'; |
Actually we have multiple other issues w/ the JS version, I'll be reporting those next... |
moving to umbrella issue |
The sample code from https://snack.expo.io/BJ6-M8pEG
When the SafeAreaView in the TabNavigator, it's margin from the parent is not correct
The text was updated successfully, but these errors were encountered: