Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMounted(...) is deprecated warning #3956

Closed
jsina opened this issue Apr 11, 2018 · 40 comments
Closed

isMounted(...) is deprecated warning #3956

jsina opened this issue Apr 11, 2018 · 40 comments

Comments

@jsina
Copy link

jsina commented Apr 11, 2018

I've get an "isMounted(...) is deprecated in plain javascript react classes" error with this dependencies, I wanna know that is there any problem with react-navigation with with "react": "16.3.1", or not?

  "dependencies": {
    "prop-types": "^15.6.1",
    "react": "16.3.1",
    "react-native": "0.55.2",
    "react-navigation": "^1.5.11"
  },
@codler
Copy link

codler commented Apr 11, 2018

I get the same warning after upgrading to react native 0.55.2

@jsina
Copy link
Author

jsina commented Apr 11, 2018

@codler I think it's for some changing in new version of react. I've find the link below. but the problem is for react-navigation api, because it's used some deprecated method.
https://medium.com/@baphemot/whats-new-in-react-16-3-d2c9b7b6193b

@kk412027247
Copy link

I also get the same warning, still can't fix it

@Ayyagaries
Copy link

Same here this is what I see
simulator screen shot - iphone 6 - 2018-04-11 at 09 28 22

@Matgsan
Copy link

Matgsan commented Apr 12, 2018

Same problem here

@kk412027247
Copy link

kk412027247 commented Apr 12, 2018

I add this code to index.js, so that i can ignore this warnning.

import { YellowBox } from 'react-native';
YellowBox.ignoreWarnings(['Warning: isMounted(...) is deprecated', 'Module RCTImageLoader']);

@hhw3KevinHou
Copy link

I got this too, and searched whole react-navigation in node_modules did not find 'isMounted()'. Weird.

@Rah1x
Copy link

Rah1x commented Apr 12, 2018

any solution?!!

@Rah1x
Copy link

Rah1x commented Apr 12, 2018

@hhw3KevinHou
image

@Rah1x
Copy link

Rah1x commented Apr 12, 2018

If you look at this entry, it was indicative enough that its going away since 2015!!. and here we are in 2018 still using it:
moreartyjs/moreartyjs#84

@hhw3KevinHou
Copy link

@Rah1x looks like isMounted() is not in react-navigation directory.

@Rah1x
Copy link

Rah1x commented Apr 12, 2018

@hhw3KevinHou
true, however this issue only came just right now as I updated react-navigation of a fine app

@derekbar90
Copy link

derekbar90 commented Apr 12, 2018

I can confirm this issue as well.

@Rah1x
Copy link

Rah1x commented Apr 12, 2018

I just followed @kk412027247 and ignored it.. not that doesnt solve the issue

@PanRada
Copy link

PanRada commented Apr 12, 2018

have same happend on new app

@JeremyBradshaw7
Copy link

Getting the same after upgrading to RN 0.55.2

@allanleonardjr
Copy link

allanleonardjr commented Apr 12, 2018

Same issue here. I followed the instructions offered by @kk412027247 in order to ignore the warning messages.

@mechanizzed
Copy link

Same issue here

"react": "16.3.1", "react-native": "0.55.2",

@MahbbRah
Copy link

Same issue....

"react": "16.3.1", "react-native": "0.55.2",

@didiercapozzi
Copy link

Same here,

"react": "16.3.1", "react-native": "0.55.2",

@jsina
Copy link
Author

jsina commented Apr 13, 2018

@kk412027247 approach is temporary. hope to be fixed for next version.

@mateoguzmana
Copy link

Same issue here
"react": "^16.2.0", "react-native": "^0.55.2"

@bcbee
Copy link

bcbee commented Apr 13, 2018

Same issue here "react": "16.3.1", "react-native": "0.55.2", "react-navigation": "^1.5.11",

@bcbee
Copy link

bcbee commented Apr 13, 2018

Can confirm this is either a bug with react-navigation, or react-navigation precipitates this bug in one of its dependencies. I created a new project and added steps to reproduction: https://github.com/brendancboyle/react-navigation-bug-3956

@TitusEfferian
Copy link

same here "react-native": "0.55.2", "react-navigation": "^1.5.11",

@charleycesar
Copy link

same here "react-native": "0.55.2"

2 similar comments
@qhkm
Copy link

qhkm commented Apr 15, 2018

same here "react-native": "0.55.2"

@buzzer-re
Copy link

same here "react-native": "0.55.2"

@alisafariir
Copy link

alisafariir commented Apr 15, 2018

how to fix this?
i've update components with npm install
my dependencies is :

{
    "react": "^16.3.1",
    "react-native": "^0.55.2",
    "react-native-vector-icons": "^4.6.0",
    "react-navigation": "^1.5.11"
}

@MultidimensionalLife
Copy link

I have the same issue. Any fix for this?

Environment:
OS: macOS Sierra 10.12.6
Node: 6.11.1
Yarn: Not Found
npm: 3.10.10
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: ^0.55.2 => 0.55.2

@RomanISWG
Copy link

Same issue here.
RN 0.55.2,
React 16.3.1,
React Navigation 1.5.11

@TheGreatAndrew
Copy link

wow just in 6 days and there are that much people having same issues.
Btw, same issue here.

@brentvatne
Copy link
Member

hello! I am on vacation and this is not an urgent issue @TheGreatAndrew - it is a warning that you can happily ignore or filter out from the yellowbox. I can address it when I'm back next week, or someone else can do it before then

@TheGreatAndrew
Copy link

naw, i did not complain, just feeling suprise. Really great library you have it there.

@brentvatne
Copy link
Member

:)

@feroce92
Copy link

feroce92 commented Apr 17, 2018

~ node_modules/react-native/Libraries/Renderer/ReactNativeRenderer-dev.js
3518, 3519 line change

@zhaiduo
Copy link

zhaiduo commented Apr 17, 2018

When I put drawerNavigation in tabNavigation, same YellowBox alert.
RN 0.55.2,
React 16.3.1,
React Navigation 1.5.8

@bingfeng1225
Copy link

same here
"react": "16.3.1",
"react-native": "0.55.2",
"react-native-root-toast": "^3.0.1",
"react-navigation": "^1.5.11"

@TPXP
Copy link

TPXP commented Apr 17, 2018

Guys I think the maintainers have enough data about this bug, could you stop posting "me too" comments which generates tons of notifications ? If you have the same problem, just put a 👍 to the first comment and subscribe to notifications 😉

@react-navigation react-navigation locked and limited conversation to collaborators Apr 17, 2018
@brentvatne
Copy link
Member

react-navigation does not use isMounted(), this is coming from somewhere inside react-native itself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests