Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider deprecation warning from react-native-gesture-handler in react-native@0.59 #5729

Closed
Steffi3rd opened this issue Mar 22, 2019 · 8 comments

Comments

@Steffi3rd
Copy link

Capture d’écran 2019-03-22 à 22 35 05

@brentvatne
Copy link
Member

this is coming from react-native-gesture-handler, cc @kmagiera @osdnk perhaps we can backport removing slider to 1.0.x line of releases and cut 1.0.18?

@Steffi3rd
Copy link
Author

Steffi3rd commented Mar 22, 2019

Same warning/error, different package : #5730

@brentvatne brentvatne changed the title ExceptionsManager.js:82 Warning: Slider has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/slider' instead of 'react-native'. Slider deprecation warning from react-native-gesture-handler in react-native@0.59 Mar 28, 2019
@chest233
Copy link

chest233 commented Apr 1, 2019

@eriveltonelias
Copy link
Member

this should fix on react-native-gesture-handler@1.2.1 can you confirm @Steffi3rd and @chest233 ?

@giacomocerquone
Copy link

giacomocerquone commented May 16, 2019

@eriveltonelias I don't think the fix should come from gesture-handler (anyway on my rn project this is a warning and not an error).
I think there should be a change in how react-navigation uses gesture-handler since if you go on gesture-handler's package.json, you won't read listed as a dependency "ViewPagerAndroid" but you can find it here, in an example of gesture-handler: https://github.com/kmagiera/react-native-gesture-handler/blob/ff74e0edadd62518b45d85f251f527307457ab9e/Example/pagerAndDrawer/index.js#L8

Do you see what it does?

const WrappedViewPagerAndroid = createNativeWrapper(ViewPagerAndroid, {
  disallowInterruption: true,
});

So must be changed react-navigation (actually one of its subpackages that uses viewpager)

@YajanaRao
Copy link

I am getting the same warning in my application. Is there any solution for this?

@bmeverett
Copy link

bmeverett commented Jun 9, 2019

Based on the commentt in #5684 upgrading to react-tabs alpha 2.0 fixed the issue. It looks like react-navigation-tabs has release v 2.1.3 so upgrading react-navigation to use v 2.1.3 of react-navigation-tabs should resolve the issue

@gbalduzzi
Copy link

I fixed the issue by upgrading react-native-gesture-handler to version 1.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants