New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a bulit in way to show a modal window that blocks the whole screen? #67
Comments
And also forgot to mention that React Navigation looks like an amazing works, and it is the missing piece we've been all waiting for (-: |
The standard |
Ok, I also see that StackNavigatorConfig has a 'modal' mode. And it also states that android is currently not supported. Are there any plans on supporting it on android? |
I have no idea on that, but you can simply use the standard React Native
This should slide over other content in the component. I've done this inside a TabNavigation earlier today and it works just fine. |
I really wouldn't use RN's @yaronlevi, What would this alternate modal style look like? We can either get one added to the library if it is a super standard component across several platforms- (please provide references!). Or we can add a way for you to customize the appearance of a standard modal stack. |
IMO there is an usecase using a screen modal would be better than RN's this is an example about style: http://browniefed.com/blog/react-native-easy-overlay-modal-with-navigator/ |
@ericvicenti Are you aware of any particular reason why the same modal animation as the one used for iOS can't be exposed? Unless I'm mistaken, it seems that implementing a slide up/down animation on Android (triggered by setting As for the look and feel, this demo from Material design's official guidelines looks good to me :-) |
I think android support for the vertical modal animation makes a lot of sense for consistency between your app, regardless of what platform it's on. When you want to make something that feels more like a modal and breaks the horizontal flow of your stack navigator, you slide up, regardless of platform. Is there a technical reason behind why this isn't possible or is it about preserving what's typical on Android? I thought the underlying animation library abstracted this stuff so it's the same code on both platforms?? Also, who really follows all these style guides anyway? Most great apps are completely custom. For example, who makes apps for iOS that are white, gray and blue, besides Apple. |
I see that it likely is possible on Android: So can't it just be at the user's discretion whether he uses Another idea is to export the TransitionConfigs, which my view is that should be done in addition. As it is, unless I'm mistaken, you can't get access to the different configs, as it's not exported but if you could, you could just set the Lastly, the next step I see is allowing you to specifying
|
Pinging OP @yaronlevi since this issue is quite old and related to an old version of the lib. If no answer I'll close in 7 days. |
Hi there @yaronlevi, In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it. If you are still having the issue (especially if it's a bug report) please open a new issue that uses the new Issue Template to provide some more details to help us solve it. |
Co-Authored-By: Satyajit Sahoo <satyajit.happy@gmail.com>
No description provided.
The text was updated successfully, but these errors were encountered: