Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom tabs have a "weird" -4 pixels offset #8642

Closed
Guuz opened this issue Jul 28, 2020 · 2 comments
Closed

Bottom tabs have a "weird" -4 pixels offset #8642

Guuz opened this issue Jul 28, 2020 · 2 comments

Comments

@Guuz
Copy link

Guuz commented Jul 28, 2020

The bottom tabs fall behind the native navigation of the phone. See screenshot (colors are to make it more obvious)
I think this is introduced here: 849e04a
const paddingBottom = Math.max(insets.bottom - 4, 0);

3 button navigation:
image
Gesture navigation:
image

Expected Behavior

Bottom tabs not to fall behind the native navigation.

How to reproduce

Use the bottom tabs, use android and have a translucent bottom navigation set.

Your Environment

software version
iOS or Android Android (probably both, more visible on Android)
@react-navigation/native 5.7.2
@react-navigation/bottom-tabs 5.7.3
react-native-screens 2.9.0
react-native 0.63.2
@github-actions
Copy link

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • @react-navigation/native (found: 5.7.1, latest: 5.7.2)
  • @react-navigation/bottom-tabs (found: 5.7.2, latest: 5.7.3)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@Guuz
Copy link
Author

Guuz commented Jul 28, 2020

Verified. This is also an issue with those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant