fix: fix header buttons not pressable when headerTransparent=true & headerMode=float #8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-example ready! Built with commit 09160d1 https://deploy-preview-8804--react-navigation-example.netlify.app |
|
Thanks for the PR. Can you provide a test plan? |
|
@satya164 just added the test plan :) |
|
Thanks for this fix. This was a blocking issue for us to release an update after upgrading navigation. |
satya164
force-pushed
the
fix/unable-to-press-header-icon
branch
from
c995df4
to
09160d1
Compare
satya164
changed the title
joshuapinter
pushed a commit
to cntral/react-navigation
that referenced
this pull request
Sep 29, 2021
…eaderMode=float (react-navigation#8804) Motivation -- Previously when using `headerMode="float"` with headerTransparent set to true, we cant press header buttons in Android. This PR fixes this. (resolves react-navigation#8731 ) Been doing some debugging and found out that this is caused by `HeaderContainer` being set as `absolute`. Initially it didn't have width & height in Android when it's set to default, that's why we can't access the children. So, the solution in this PR is to define the height by using headerHeight. But, since we can't access headerHeight from header, Im using local state for keeping up with the headerHeight. Or should I move the HeaderHeight provider out of StackContainer? I'm not sure, since I think it was intended to be kept inside the StackContainer Test Plan -- With this config, now the header button can be clicked. Tested in both platform ```typescript <Stack.Navigator headerMode="float" screenOptions={{ headerTransparent: true }} > <Stack.Screen name="Home Screen" component={Home} /> <Stack.Screen name="Details Screen" component={Details} /> </Stack.Navigator> ``` Android: -  iOS: -- <img width="300" src="https://user-images.githubusercontent.com/24470609/94682743-9a3e3580-034f-11eb-8e90-2d31748bde5c.gif" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously when using
headerMode="float"with headerTransparent set to true, we cant press header buttons in Android. This PR fixes this. (resolves #8731 )Been doing some debugging and found out that this is caused by
HeaderContainerbeing set asabsolute. Initially it didn't have width & height in Android when it's set to default, that's why we can't access the children.So, the solution in this PR is to define the height by using headerHeight. But, since we can't access headerHeight from header, Im using local state for keeping up with the headerHeight. Or should I move the HeaderHeight provider out of StackContainer? I'm not sure, since I think it was intended to be kept inside the StackContainer
Test Plan
With this config, now the header button can be clicked. Tested in both platform
Android:
iOS: