feat: add optional screens per navigator #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-example ready! Built with commit cf60b79 https://deploy-preview-8805--react-navigation-example.netlify.app |
|
The Expo app for the example from this branch is ready! expo.io/@react-navigation/react-navigation-example?release-channel=pr-8805 |
jkadamczyk
approved these changes
Sep 7, 2020
WoLewicki
force-pushed
the
@wolewicki/optional-screens
branch
from
e436e39
to
242b379
Compare
Codecov Report
@@ Coverage Diff @@
## main #8805 +/- ##
==========================================
- Coverage 74.50% 74.10% -0.40%
==========================================
Files 131 131
Lines 3204 3236 +32
Branches 967 982 +15
==========================================
+ Hits 2387 2398 +11
- Misses 715 734 +19
- Partials 102 104 +2
Continue to review full report at Codecov.
|
satya164
reviewed
Oct 23, 2020
satya164
approved these changes
Oct 23, 2020
1 task
This was referenced Jun 6, 2021
Open
Open
This was referenced Jul 20, 2021
Closed
1 task
joshuapinter
pushed a commit
to cntral/react-navigation
that referenced
this pull request
Sep 29, 2021
Changes done here will work properly with software-mansion/react-native-screens#624 merged and released. The documentation of `screensEnabled` and `activeLimit` props should also be added. It also enabled `Screens` in iOS stack-navigator by default. New things: - `detachInactiveScreens` - prop for navigators with `react-native-screens` integration that can be set by user. It controls if the `react-native-screens` are used by the navigator. - `detachPreviousScreen` - option that tells to keep the previous screen active. It can be set by user, defaults to `true` for normal mode and `false` for the last screen for mode = “modal”. Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done here will work properly with software-mansion/react-native-screens#624 merged and released. The documentation of
detachInactiveScreensanddetachPreviousScreenprops should also be added.New things:
detachInactiveScreens- prop for all navigators that can be switched by the user. It controls if thereact-native-screensare used by the navigator.detachPreviousScreen- a prop that tells if the previous screen should stay active after the transition. It can be set by the user, defaults totruefor normal mode, andtruefor mode = “modal”.