feat: add sceneContainerStyle prop to bottom-tabs navigator #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-navigation-example ready! Built with commit 07de936 https://deploy-preview-8947--react-navigation-example.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #8947 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 131 131
Lines 3231 3231
Branches 998 998
=======================================
Hits 2399 2399
Misses 727 727
Partials 105 105
Continue to review full report at Codecov.
|
satya164
requested changes
Oct 22, 2020
satya164
reviewed
Oct 22, 2020
satya164
reviewed
Oct 23, 2020
|
Hi @satya164, thanks so much for approving this! Just to let you know, I prepared a PR for the website to document this as well: react-navigation/react-navigation.github.io#877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the sceneContainerStyle prop to the bottom-tabs navigator, to allow setting styles on the container's view. It's already implemented in the material-top-tabs and drawer navigators, I've simply ported it into the bottom-tabs navigator.
It also fixes this issue:
#8076