Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect headerStatusBarHeight option in Stack #9405

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

adamTrz
Copy link
Contributor

@adamTrz adamTrz commented Mar 10, 2021

Use headerStatusBarHeight that was passed in options

Use `headerStatusBarHeight` that was passed in `options`
@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for react-navigation-example ready!

Built with commit a68f806

https://deploy-preview-9405--react-navigation-example.netlify.app

@codecov-io
Copy link

Codecov Report

Merging #9405 (a68f806) into main (bfd6eb7) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9405      +/-   ##
==========================================
- Coverage   74.12%   74.10%   -0.03%     
==========================================
  Files         143      143              
  Lines        3436     3437       +1     
  Branches     1071     1072       +1     
==========================================
  Hits         2547     2547              
  Misses        772      772              
- Partials      117      118       +1     
Impacted Files Coverage Δ
packages/stack/src/views/Header/Header.tsx 68.75% <50.00%> (-4.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd6eb7...a68f806. Read the comment docs.

@satya164 satya164 changed the title Respect headerStatusBarHeight passed fix: respect headerStatusBarHeight option in Stack Mar 11, 2021
@satya164 satya164 merged commit 8a6511c into react-navigation:main Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants