Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blink while switching screens #9705

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Conversation

libesto
Copy link
Contributor

@libesto libesto commented Jun 27, 2021

Fix to prevent showing blank screen while screens switching process.
Currently we can see it using dark background color in screens.
This fix also makes clear work with eager loading of screens (detachInactiveScreens={false} lazy={false}).

@github-actions
Copy link

Hey Libesto! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2021

Codecov Report

Merging #9705 (567c67e) into main (b1d935c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9705   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         159      159           
  Lines        4586     4586           
  Branches     1725     1725           
=======================================
  Hits         3427     3427           
  Misses       1129     1129           
  Partials       30       30           
Impacted Files Coverage Δ
packages/drawer/src/views/DrawerView.tsx 73.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d935c...567c67e. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 27, 2021

✔️ Deploy Preview for react-navigation-example ready!

🔨 Explore the source changes: 567c67e

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/60d8557fdbfde8000755f747

😎 Browse the preview: https://deploy-preview-9705--react-navigation-example.netlify.app

@libesto libesto changed the title fixing blink while switching screens fix: blink while switching screens Jun 27, 2021
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Sounds like a smart fix.

@satya164 satya164 merged commit 99735e1 into react-navigation:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants