Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix useLinkTo crash when an object is passed as a parameter #9800

Merged
merged 1 commit into from Aug 7, 2021
Merged

fix: fix useLinkTo crash when an object is passed as a parameter #9800

merged 1 commit into from Aug 7, 2021

Conversation

giannismacheras
Copy link
Contributor

When an object was passed to the to parameter in useLinkTo, an error message would be thrown (Cannot find property 'root'). Apparently, this was introduced in commit 1d40279, where the root variable was removed.

When an object was passed to the `to` parameter in `useLinkTo`, an error message would be thrown (Cannot find property 'root'). Apparently, this was introduced in commit 1d40279, where the `root` variable was removed.
@github-actions
Copy link

github-actions bot commented Aug 7, 2021

Hey LuckyLuke19! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@giannismacheras giannismacheras changed the title Fix useLinkTo crash when an object is passed as a parameter fix: fix useLinkTo crash when an object is passed as a parameter Aug 7, 2021
@netlify
Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for react-navigation-example ready!

🔨 Explore the source changes: 8da76ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/610e66aba4c0740008f62f01

😎 Browse the preview: https://deploy-preview-9800--react-navigation-example.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #9800 (8da76ec) into main (3aab9fd) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9800   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files         159      159           
  Lines        4696     4696           
  Branches     1770     1770           
=======================================
  Hits         3504     3504           
  Misses       1161     1161           
  Partials       31       31           
Impacted Files Coverage Δ
packages/native/src/useLinkTo.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aab9fd...8da76ec. Read the comment docs.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

@satya164 satya164 merged commit dfd0cc7 into react-navigation:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants