fix: make useScrollToTop work with react-native-largelist #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey doomsower! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
|
✔️ Deploy Preview for react-navigation-example ready! 🔨 Explore the source changes: 029bd69 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/614c923b2e941a0008327932 😎 Browse the preview: https://deploy-preview-9960--react-navigation-example.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## main #9960 +/- ##
=======================================
Coverage 74.51% 74.51%
=======================================
Files 159 159
Lines 4764 4764
Branches 1798 1798
=======================================
Hits 3550 3550
Misses 1181 1181
Partials 33 33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes
useScrollToTopwork withreact-native-largelist. Otherwise you get errorArgument 1 (CGFloat) of SpringScrollView.scrollTo must not be null. Should not break anything, because it's still compatible with originalscrollTosignature.