Website: command-click should not handle inside page #9
Comments
|
Can somebody help fix this? Should be pretty easy to add a special case in the onClick handler: https://github.com/react-community/react-navigation/blob/master/website/src/Link.js#L30 |
|
It really worries me that that navigation requires special JS routing rather than just working with browser events. It means you have to implement hacks like the one you suggested, or the one in the referenced PR. |
|
@irskep , sorry I'm a bit confused what the hack is. Because of the server rendering, React Navigation works great in browsers without JS. So I would not say it requires special JS routing. For browsers that do have JS, we can improve page load time by blocking the browser navigation, and switching pages in JS. This will also allow us to implement animations and make the app feel faster. There is no other standard way to speed up page transitions, so this technique is not considered a hack. It is a web standard and is supported by all major browsers. |
Routes in `MaterialTopTabNavigator` are now lazy initialized like in `MaterialBottomTabNavigator`. A scene visibility is computed from multiple states and props: To handle the pan between tabs, we check if you're currently swiping between tabs and the prop `lazyOnSwipe` is true (default value) or if the tab have been already loaded, we'll check if this tab is a sibling of the focused tab. Then, we'll display the tab if it's a sibling. ~With the prop `animationEnabled` to true, we shouldn't hide a tab before the transition is done. So we're waiting `COMPLETE_TRANSITION` action to hide it. Also, if the prop `sceneAlwaysVisible` is true (default value), we won't hide scenes between A and D while transitioning.~ If the current tab has not been loaded and must not be visible, we do not render it. I'll update the docs accordingly to this PR.  <!-- #### Default behavior Tabs are lazy initialized on swipe or focus and are always visible while transitioning.  #### Hide tabs between while transitioning ```js { sceneAlwaysVisible: false, } ```  #### Fallback to only lazy initialized tabs on focus ```js { lazyOnSwipe: false, } ```  -->
fix: avoid stringified "null" and "undefined" values
Cmd-click on the website is broken
The text was updated successfully, but these errors were encountered: