Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Rewrite stack navigator #131

Merged
merged 56 commits into from Jul 8, 2019
Merged

Rewrite stack navigator #131

merged 56 commits into from Jul 8, 2019

Conversation

satya164
Copy link
Member

@satya164 satya164 commented May 24, 2019 •
edited

This is a re-implementation of stack navigator using kmagiera/react-native-reanimated.

TODO

@satya164 satya164 changed the title Rewrite stack animation Rewrite stack navigator May 24, 2019
@satya164 satya164 force-pushed the @satya164/reanimated-stacks branch 11 times, most recently from 4f3babe to 883a169 Compare May 31, 2019 12:41
@satya164 satya164 force-pushed the @satya164/reanimated-stacks branch 18 times, most recently from 44a2442 to 2ae1ea5 Compare June 4, 2019 19:43
@satya164 satya164 mentioned this pull request Jun 26, 2019
Closed
@brentvatne brentvatne mentioned this pull request Jul 4, 2019
Closed
@brentvatne
Copy link
Member

in uikit example:

  1. push a screen
  2. push a screen with no header
  3. go back and the content is under the header

@satya164
Copy link
Member Author

satya164 commented Jul 4, 2019

@brentvatne is it alpha or latest commit?

tchayen and others added 14 commits July 6, 2019 12:41
@tchayen @satya164
feat: allow specifying style interpolators in navigationOptions (#155)
16823e3
@satya164
chore: upgrade deps
f41380f
@satya164
fix: hide overflow in wipe preset
a6335bd
@satya164
fix: fix typo preventing the screen from being cleaned up
f173a16
@satya164
fix: disable react-native-screens on iOS
f43800b
@osdnk @satya164
feat: add on transition end callback (#153)
a32e43a
@satya164
fix: fix back button not working in header
9d17440
@satya164
chore: release 2.0.0-alpha.3
05e1f31
@satya164
fix: properly handle floating header height
68bd0f4 
Previously, the header height wasn't stored per screen. This resulted in header height always referring to the one in last mounted screen.
As a result, the top margin for screens were incorrect.

This resulted in bugs such as when you go to a screen with no header, header height will stay 0 even after navigating back.

This commit stores the height for each screen separately, handling this properly.
@satya164
chore: release 2.0.0-alpha.4
973aef1
@satya164
fix: don't enable screens for modal stacks
f04b9bf
@satya164
fix: tweak transition spec to prevent jumping effect
3f5b903
@satya164
refactor: export a modal transition preset
b3c7250
@satya164
chore: release 2.0.0-alpha.5
67a942d
@jerolimov
Copy link

jerolimov commented Jul 8, 2019 •
edited

Hey @satya164, create work in the reanimated-stacks alpha branch. 👍

I use already the branch and the alpha versions of the react-navigation-stack. Why did you disable screens (f04b9bf) in the latest alpha for modal dialogs? Using screens and also the new iOS 13 effect was one reason for me to use already the alpha.

(edit: After updating from alpha.2 to alpha.5 is lost the new iOS 13 modal effect. I switched back to the old version for now.)

@satya164
Copy link
Member Author

satya164 commented Jul 8, 2019 •
edited

Why did you disable screens in the latest alpha for modal dialogs

Because for modals such as ModalPresentationIOS, the previous screen needs to be visible underneath. If screens is enabled, the previous screen will be removed from the tree, and screens has a bug which doesn't make it possible to keep last 2 screens active at the same time.

The only things mode: 'modal' does are pick a default transition and disable screens. You don't have to use it, you can specify custom transition.

After updating from alpha.2 to alpha.5 is lost the new iOS 13 modal effect

Please read the release notes: https://github.com/react-navigation/stack/releases/tag/v2.0.0-alpha.3

@satya164
Copy link
Member Author

satya164 commented Jul 8, 2019

Merging this to master and continue development from there. This will make sure any new PRs and issues we receive are against the latest changes.

@satya164 satya164 merged commit ea29e14 into master Jul 8, 2019
@jerolimov
Copy link

Thanks for the fast feedback @satya164

With moving the TransitionPreset attributes into the defaultNavigationOptions it works great with alpha.5 again. 👍

@satya164 satya164 deleted the @satya164/reanimated-stacks branch July 8, 2019 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@osdnk osdnk osdnk approved these changes

@ericvicenti ericvicenti Awaiting requested review from ericvicenti

@kmagiera kmagiera Awaiting requested review from kmagiera

Assignees

@osdnk osdnk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@satya164 @brentvatne @jerolimov @kmagiera @osdnk @tchayen