-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add tests #14
Closed
Closed
[WIP] add tests #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inject to devtool
e573854
to
c9308b4
Compare
Awesome! I will review the changes when I get back home next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experimentally added testing based on visual regression test with nightwatch.js.
Idea
In visual regression test, a baseline screenshot and a current screenshot of a target page url are expected to be the same image. Normally both screenshots are taken on the same url.
Borrowing this idea for testing PaperRenderer, screenshots of following pages should be compared.
What I Implemented
create-react-app
inside test foldernpm run test
first launches testing app, and then runnightwatch
to compare screenshots of the pages.I confirmed it works on MacOS.
Reference
htps://github.com/Rykus0/nightwatch-visual-regression