Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build issue with Node.js 17 #13

Closed
brodybits opened this issue Dec 2, 2021 · 0 comments
Closed

build issue with Node.js 17 #13

brodybits opened this issue Dec 2, 2021 · 0 comments
Assignees

Comments

@brodybits
Copy link
Collaborator

brodybits commented Dec 2, 2021

After pushing 135f17d I encountered a CI failure to a build issue & found a workaround ref:

and webpack seems to be used via rollup-plugin-size-snapshot:

% yarn why webpack
yarn why v1.22.17
[1/4] 🤔  Why do we have the module "webpack"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "webpack@4.46.0"
info Reasons this module exists
   - "rollup-plugin-size-snapshot" depends on it
   - Hoisted from "rollup-plugin-size-snapshot#webpack"
[...]

The result of using webpack seems to be relevant in only one place in .size-snapshot.json.

I really hope they will resolve the underlying issue in webpack/webpack#14532 in the near future.

Should now be resolved by updating rollup-plugin-size-snapshot to use recent Webpack v5 update ref: webpack/webpack#14532 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant